Skip to content

Fix broken URLs and links #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Fix broken URLs and links #827

merged 2 commits into from
Feb 9, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Feb 7, 2023

What This PR Changes

A report was received that the URL in one of the library tutorials did not work: arduino-libraries/LiquidCrystal#65

While I was fixing that, I did a non-comprehensive survey for other non-functional URLs and links the once I found also fixed here. They fall into two classes:

  • Malformed URLs caused by a failed replace operation
  • URLs for pages that have been moved without setting up a redirect

Contribution Guidelines

It appears an incorrectly performed replace operation corrupted the URLs in the sketch header comments that link to the
associated tutorial page.
The organization of the pages under arduino.cc are in a constant state of flux. There is some attempt to set up
redirects from the old URLs, but this is done inconsistently, breaking the links to the previous pages.
@per1234 per1234 added bug Something isn't working arduino Bugs and fixes added by the Arduino Team labels Feb 7, 2023
@per1234 per1234 self-assigned this Feb 7, 2023
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebromero sebromero merged commit 100aeff into arduino:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants