Skip to content

Bump codecov/codecov-action workflow dependency to v2 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Bump codecov/codecov-action workflow dependency to v2 #238

merged 1 commit into from
Aug 5, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 5, 2021

The codecov/codecov-action action is used in the unit test runner workflow to upload code coverage data to codecov. The workflow is configured to use the latest release within the specified major version series. It is necessary to manually update the workflow any time a new major version series of an action begins, in which case a review is necessary to determine whether the workflow is affected by the breaking changes that required the major bump.

The action is now in its 2.x version series. The cause of the major bump was the removal of some of the action's inputs. I reviewed the changes and found that none of the inputs used in the workflow are affected so it is possible to update without any other changes to the workflow.

This pull request supersedes #230. That was an example of Dependabot attempting to pin the action to a specific minor version rather than our preferred default approach of only pinning the major version ref. The reason is that the specific version tag in the codecov/codecov-action repository was created after the major ref tag was moved (Dependabot picks the most recent tag to use as the action ref in its workflow update PRs). Even though it was not possible to use Dependabot's PR in this case, it still served as a helpful notification that a new action version is available.

The `codecov/codecov-action` action is used in the unit test runner workflow to upload code coverage data to codecov. The
workflow is configured to use the latest release within the specified major version series. It is necessary to manually
update the workflow any time a new major version series of an action begins, in which case a review is necessary to
determine whether the workflow is affected by the breaking changes that required the major bump.

The action is now in its 2.x version series. The cause of the major bump was the removal of some of the action's inputs.
I reviewed the changes and found that none of the inputs used in the workflow are affected so it is possible to update
without any other changes to the workflow.
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 5, 2021
@per1234 per1234 requested review from silvanocerza and umbynos August 5, 2021 11:59
@per1234 per1234 merged commit bf7335b into arduino:main Aug 5, 2021
@per1234 per1234 deleted the bump-codecov-action branch August 5, 2021 18:50
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants