Make schema.pathURI() produce specification-compliant URIs from Windows paths #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
commented
Nov 6, 2020
…ws paths The path in a `file` URI must always start with `/`, but Windows paths do not.
per1234
force-pushed
the
per1234/valid-windows-file-uri
branch
from
8f2da0e to
c7241eb
Compare
silvanocerza
approved these changes
Nov 6, 2020
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path in a
fileURI must always start with/, but Windows paths do not.The current JSON schema validation package has code to handle the missing slash, but the package that will be transitioned requires the correct format.
I did quite a bit of searching for a canonical Golang way of doing this and was surprised to find nothing.
Reference:
https://docs.microsoft.com/en-us/archive/blogs/ie/file-uris-in-windows#proper-syntax