-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add JSON schema for platform.txt #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to do validation against the JSON schema the native properties.Map format of the Arduino project configuration files must be converted to the map[string]interface{} type. This process is made more complex by the need to selectively recurse the data into multiple key levels. Previously, this was done in three different places in the code, each tailored to the specific needs of the configuration files it worked with, and using slightly different approaches. Unifying all that code into a single general purpose function will make the code easier to maintain.
This schema defines the required data structure of the platform.txt configuration file of Arduino boards platforms.
silvanocerza
reviewed
Jan 7, 2021
silvanocerza
reviewed
Jan 7, 2021
silvanocerza
reviewed
Jan 7, 2021
silvanocerza
reviewed
Jan 7, 2021
silvanocerza
reviewed
Jan 7, 2021
silvanocerza
suggested changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
The platform support is now near to complete, so worth mentioning.
9726733
to
f4a6274
Compare
silvanocerza
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the JSON schema and all rules based on it.