Skip to content

Add JSON schema for platform.txt #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Add JSON schema for platform.txt #139

merged 3 commits into from
Jan 7, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jan 7, 2021

Provide the JSON schema and all rules based on it.

In order to do validation against the JSON schema the native properties.Map format of the Arduino project configuration
files must be converted to the map[string]interface{} type. This process is made more complex by the need to selectively
recurse the data into multiple key levels.

Previously, this was done in three different places in the code, each
tailored to the specific needs of the configuration files it worked with, and using slightly different approaches.

Unifying all that code into a single general purpose function will make the code easier to maintain.
This schema defines the required data structure of the platform.txt configuration file of Arduino boards platforms.
@per1234 per1234 requested a review from silvanocerza January 7, 2021 11:29
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

The platform support is now near to complete, so worth mentioning.
@per1234 per1234 force-pushed the per1234/platform-schemas branch from 9726733 to f4a6274 Compare January 7, 2021 14:45
@per1234 per1234 merged commit a3744c7 into main Jan 7, 2021
@per1234 per1234 deleted the per1234/platform-schemas branch January 7, 2021 16:15
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Sep 29, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants