[WIP]: ATL-1055 Update app icons

[sebromero]

This PR updates the icons to look all the same on the different OS. Windows and Linux need to be tested.

[sebromero]

Not sure if that's still an issue: https://github.com/arduino/arduino-pro-ide/issues/123 but let's double check before we merge this.

[rsora]

Thanks @sebromero!
[Windows] I tested the new icons on windows and it seems that they are a little blurried compared to the previous release (see screenshots).
before

after

In addition it seems that the icon on the titlebar is not there anymore, I think we need a double check from @kittaakos on that.

[Linux] as you mentioned, there is still an Issue on linux, I could not test the new icon 😿,but I found an electron builder issue electron-userland/electron-builder#2269 that seems to contain the solution for arduino/arduino-pro-ide#123, maybe @kittaakos could take a look at the solution here electron-userland/electron-builder#2269 (comment) and see if it's applicable to the our IDE.

[kittaakos]

maybe @kittaakos could take a look at the solution here

Sure. I will handle that in another PR. This PR should be about the new icons only.

In addition it seems that the icon on the titlebar is not there anymore, I think we need a double check from @kittaakos on that.

What should I do it here? If it works from the main, it is clearly an icon issue or something with its format.

[rsora]

it is clearly an icon issue or something with its format

@sebromero can you please check if the format was changed anyhow, compared to the previous icons?
Thanks!

[sebromero]

@rsora Try again please. The Windows issues should be fixed.

[rsora]

Thanks @sebromero!
Icons are fine now on windows!
We can merge 👍

[sebromero]

@rsora Can we test "manually" on LInux so we're sure that it works there too once we resolve the issue of the icon not being displayed?

[kittaakos]

@sebromero, please squash the commits before the merge. Thank you!

on LInux
icon not being displayed?

I will take care of that part in a separate PR if you're OK with it.

[sebromero]

@kittaakos I was just thinking if we could test it on Linux somehow just to see if the icon looks good visually before we merge, but I can make another PR later for that if necessary.

[sebromero]

@kittaakos @rsora Why is "Squash and merge" not enabled for this repo? Can we enable it?

[rsora]

@sebromero creating manually a .desktop file in Ubuntu, I can see the icon on the launcher with no defects 👍

@kittaakos please merge this!

[kittaakos]

Why is "Squash and merge" not enabled for this repo? Can we enable it?

Because it's not what we always want to have. Check the other PR (https://github.com/arduino/arduino-ide/pull/25/commits), why would we want to squash the commits.

[kittaakos]

@kittaakos please merge this!

I am going to squash it and force push. No need to have to commits for one change.

[kittaakos]

@kittaakos please merge this!

I am going to squash it and force push. No need to have to commits for one change.

OK. Never mind.