no-merge: composite PR of #1969 and #1970 #1971
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2023 14:50
the smaller the timeout the better chance you have to see the duplicate editors. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
to avoid duplicate editor tabs when opening a sketch with no previously saved workbench layout Closes #1791 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
added
conclusion: invalid
4 tasks
kittaakos
added
status: on hold
|
This PR was created to simplify the verification of #1969. |
per1234
added
conclusion: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO MERGE
Motivation
This PR is to help verify #1969. This exposes the preferences to tune the editor timeout + also contains the fix. Once you have gone through the steps of #1970, you can try the same with this PR. If you do not see duplicate editor tabs, it proves #1969 fixes the incorrect widget key calculation.
fix_editor_timeout.mp4
Change description
Other information
Reviewer checklist