Skip to content

Commit d5c7d3a

Browse files
authored
Merge pull request #140 from bcmi-labs/0.1.0-rc
0.1.0 rc
2 parents 0363041 + 0ddfa1c commit d5c7d3a

File tree

10 files changed

+29
-17
lines changed

10 files changed

+29
-17
lines changed

arduino-debugger-extension/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"name": "arduino-debugger-extension",
3-
"version": "0.0.7",
3+
"version": "0.1.0",
44
"description": "An extension for debugging Arduino programs",
55
"license": "MIT",
66
"dependencies": {
77
"@theia/debug": "next",
8-
"arduino-ide-extension": "0.0.7",
8+
"arduino-ide-extension": "0.1.0",
99
"cdt-gdb-adapter": "^0.0.14",
1010
"vscode-debugadapter": "^1.26.0",
1111
"vscode-debugprotocol": "^1.26.0"

arduino-ide-extension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "arduino-ide-extension",
3-
"version": "0.0.7",
3+
"version": "0.1.0",
44
"description": "An extension for Theia building the Arduino IDE",
55
"license": "MIT",
66
"scripts": {

arduino-ide-extension/scripts/download-cli.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
(() => {
1212

13-
const DEFAULT_VERSION = '0.12.0-rc2'; // require('moment')().format('YYYYMMDD');
13+
const DEFAULT_VERSION = '0.12.0'; // require('moment')().format('YYYYMMDD');
1414

1515
const path = require('path');
1616
const shell = require('shelljs');

arduino-ide-extension/src/browser/contributions/upload-sketch.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,20 +98,27 @@ export class UploadSketch extends SketchContribution {
9898
let options: CoreService.Upload.Options | undefined = undefined;
9999
const sketchUri = uri;
100100
const optimizeForDebug = this.editorMode.compileForDebug;
101+
const { selectedPort } = boardsConfig;
101102

102103
if (usingProgrammer) {
103104
const programmer = selectedProgrammer;
104105
if (!programmer) {
105106
throw new Error('Programmer is not selected. Please select a programmer.');
106107
}
108+
let port: undefined | string = undefined;
109+
// If the port is set by the user, we pass it to the CLI as it might be required.
110+
// If it is not set but the CLI requires it, we let the CLI to complain.
111+
if (selectedPort) {
112+
port = selectedPort.address;
113+
}
107114
options = {
108115
sketchUri,
109116
fqbn,
110117
optimizeForDebug,
111-
programmer
118+
programmer,
119+
port
112120
};
113121
} else {
114-
const { selectedPort } = boardsConfig;
115122
if (!selectedPort) {
116123
throw new Error('No ports selected. Please select a port.');
117124
}

arduino-ide-extension/src/browser/theia/core/application-shell.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import { injectable, inject } from 'inversify';
33
import { EditorWidget } from '@theia/editor/lib/browser';
44
import { CommandService } from '@theia/core/lib/common/command';
5+
import { OutputWidget } from '@theia/output/lib/browser/output-widget';
56
import { ApplicationShell as TheiaApplicationShell, Widget } from '@theia/core/lib/browser';
67
import { Sketch } from '../../../common/protocol';
78
import { EditorMode } from '../../editor-mode';
@@ -22,6 +23,9 @@ export class ApplicationShell extends TheiaApplicationShell {
2223

2324
protected track(widget: Widget): void {
2425
super.track(widget);
26+
if (widget instanceof OutputWidget) {
27+
widget.title.closable = false; // TODO: https://arduino.slack.com/archives/C01698YT7S4/p1598011990133700
28+
}
2529
if (!this.editorMode.proMode && widget instanceof EditorWidget) {
2630
// Make the editor un-closeable asynchronously.
2731
this.sketchesServiceClient.currentSketch().then(sketch => {

arduino-ide-extension/src/common/protocol/core-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export namespace CoreService {
2626
export namespace Upload {
2727
export type Options =
2828
Compile.Options & Readonly<{ port: string }> |
29-
Compile.Options & Readonly<{ programmer: Programmer }>;
29+
Compile.Options & Readonly<{ programmer: Programmer, port?: string }>;
3030
}
3131

3232
}

arduino-ide-extension/src/node/core-service-impl.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,12 @@ export class CoreServiceImpl implements CoreService {
103103
uploadReq.setInstance(instance);
104104
uploadReq.setSketchPath(sketchpath);
105105
uploadReq.setFqbn(fqbn);
106-
if ('port' in options) {
107-
uploadReq.setPort(options.port);
108-
} else {
106+
if ('programmer' in options) {
109107
uploadReq.setProgrammer(options.programmer.id);
110108
}
109+
if (options.port) {
110+
uploadReq.setPort(options.port);
111+
}
111112
const result = client.upload(uploadReq);
112113

113114
try {

browser-app/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"private": true,
33
"name": "browser-app",
4-
"version": "0.0.7",
4+
"version": "0.1.0",
55
"license": "MIT",
66
"dependencies": {
77
"@theia/core": "next",
@@ -19,8 +19,8 @@
1919
"@theia/process": "next",
2020
"@theia/terminal": "next",
2121
"@theia/workspace": "next",
22-
"arduino-ide-extension": "0.0.7",
23-
"arduino-debugger-extension": "0.0.7"
22+
"arduino-ide-extension": "0.1.0",
23+
"arduino-debugger-extension": "0.1.0"
2424
},
2525
"devDependencies": {
2626
"@theia/cli": "next"

electron-app/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"private": true,
33
"name": "electron-app",
4-
"version": "0.0.7",
4+
"version": "0.1.0",
55
"license": "MIT",
66
"main": "src-gen/frontend/electron-main.js",
77
"dependencies": {
@@ -21,8 +21,8 @@
2121
"@theia/process": "next",
2222
"@theia/terminal": "next",
2323
"@theia/workspace": "next",
24-
"arduino-ide-extension": "0.0.7",
25-
"arduino-debugger-extension": "0.0.7"
24+
"arduino-ide-extension": "0.1.0",
25+
"arduino-debugger-extension": "0.1.0"
2626
},
2727
"devDependencies": {
2828
"@theia/cli": "next"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "arduino-editor",
3-
"version": "0.0.7",
3+
"version": "0.1.0",
44
"description": "Arduino Pro IDE",
55
"repository": "https://github.com/bcmi-labs/arduino-editor.git",
66
"author": "Arduino SA",

0 commit comments

Comments
 (0)