File tree 10 files changed +29
-17
lines changed
arduino-debugger-extension 10 files changed +29
-17
lines changed Original file line number Diff line number Diff line change 1
1
{
2
2
"name" : " arduino-debugger-extension" ,
3
- "version" : " 0.0.7 " ,
3
+ "version" : " 0.1.0 " ,
4
4
"description" : " An extension for debugging Arduino programs" ,
5
5
"license" : " MIT" ,
6
6
"dependencies" : {
7
7
"@theia/debug" : " next" ,
8
- "arduino-ide-extension" : " 0.0.7 " ,
8
+ "arduino-ide-extension" : " 0.1.0 " ,
9
9
"cdt-gdb-adapter" : " ^0.0.14" ,
10
10
"vscode-debugadapter" : " ^1.26.0" ,
11
11
"vscode-debugprotocol" : " ^1.26.0"
Original file line number Diff line number Diff line change 1
1
{
2
2
"name" : " arduino-ide-extension" ,
3
- "version" : " 0.0.7 " ,
3
+ "version" : " 0.1.0 " ,
4
4
"description" : " An extension for Theia building the Arduino IDE" ,
5
5
"license" : " MIT" ,
6
6
"scripts" : {
Original file line number Diff line number Diff line change 10
10
11
11
( ( ) => {
12
12
13
- const DEFAULT_VERSION = '0.12.0-rc2 ' ; // require('moment')().format('YYYYMMDD');
13
+ const DEFAULT_VERSION = '0.12.0' ; // require('moment')().format('YYYYMMDD');
14
14
15
15
const path = require ( 'path' ) ;
16
16
const shell = require ( 'shelljs' ) ;
Original file line number Diff line number Diff line change @@ -98,20 +98,27 @@ export class UploadSketch extends SketchContribution {
98
98
let options : CoreService . Upload . Options | undefined = undefined ;
99
99
const sketchUri = uri ;
100
100
const optimizeForDebug = this . editorMode . compileForDebug ;
101
+ const { selectedPort } = boardsConfig ;
101
102
102
103
if ( usingProgrammer ) {
103
104
const programmer = selectedProgrammer ;
104
105
if ( ! programmer ) {
105
106
throw new Error ( 'Programmer is not selected. Please select a programmer.' ) ;
106
107
}
108
+ let port : undefined | string = undefined ;
109
+ // If the port is set by the user, we pass it to the CLI as it might be required.
110
+ // If it is not set but the CLI requires it, we let the CLI to complain.
111
+ if ( selectedPort ) {
112
+ port = selectedPort . address ;
113
+ }
107
114
options = {
108
115
sketchUri,
109
116
fqbn,
110
117
optimizeForDebug,
111
- programmer
118
+ programmer,
119
+ port
112
120
} ;
113
121
} else {
114
- const { selectedPort } = boardsConfig ;
115
122
if ( ! selectedPort ) {
116
123
throw new Error ( 'No ports selected. Please select a port.' ) ;
117
124
}
Original file line number Diff line number Diff line change 2
2
import { injectable , inject } from 'inversify' ;
3
3
import { EditorWidget } from '@theia/editor/lib/browser' ;
4
4
import { CommandService } from '@theia/core/lib/common/command' ;
5
+ import { OutputWidget } from '@theia/output/lib/browser/output-widget' ;
5
6
import { ApplicationShell as TheiaApplicationShell , Widget } from '@theia/core/lib/browser' ;
6
7
import { Sketch } from '../../../common/protocol' ;
7
8
import { EditorMode } from '../../editor-mode' ;
@@ -22,6 +23,9 @@ export class ApplicationShell extends TheiaApplicationShell {
22
23
23
24
protected track ( widget : Widget ) : void {
24
25
super . track ( widget ) ;
26
+ if ( widget instanceof OutputWidget ) {
27
+ widget . title . closable = false ; // TODO: https://arduino.slack.com/archives/C01698YT7S4/p1598011990133700
28
+ }
25
29
if ( ! this . editorMode . proMode && widget instanceof EditorWidget ) {
26
30
// Make the editor un-closeable asynchronously.
27
31
this . sketchesServiceClient . currentSketch ( ) . then ( sketch => {
Original file line number Diff line number Diff line change @@ -26,7 +26,7 @@ export namespace CoreService {
26
26
export namespace Upload {
27
27
export type Options =
28
28
Compile . Options & Readonly < { port : string } > |
29
- Compile . Options & Readonly < { programmer : Programmer } > ;
29
+ Compile . Options & Readonly < { programmer : Programmer , port ?: string } > ;
30
30
}
31
31
32
32
}
Original file line number Diff line number Diff line change @@ -103,11 +103,12 @@ export class CoreServiceImpl implements CoreService {
103
103
uploadReq . setInstance ( instance ) ;
104
104
uploadReq . setSketchPath ( sketchpath ) ;
105
105
uploadReq . setFqbn ( fqbn ) ;
106
- if ( 'port' in options ) {
107
- uploadReq . setPort ( options . port ) ;
108
- } else {
106
+ if ( 'programmer' in options ) {
109
107
uploadReq . setProgrammer ( options . programmer . id ) ;
110
108
}
109
+ if ( options . port ) {
110
+ uploadReq . setPort ( options . port ) ;
111
+ }
111
112
const result = client . upload ( uploadReq ) ;
112
113
113
114
try {
Original file line number Diff line number Diff line change 1
1
{
2
2
"private" : true ,
3
3
"name" : " browser-app" ,
4
- "version" : " 0.0.7 " ,
4
+ "version" : " 0.1.0 " ,
5
5
"license" : " MIT" ,
6
6
"dependencies" : {
7
7
"@theia/core" : " next" ,
19
19
"@theia/process" : " next" ,
20
20
"@theia/terminal" : " next" ,
21
21
"@theia/workspace" : " next" ,
22
- "arduino-ide-extension" : " 0.0.7 " ,
23
- "arduino-debugger-extension" : " 0.0.7 "
22
+ "arduino-ide-extension" : " 0.1.0 " ,
23
+ "arduino-debugger-extension" : " 0.1.0 "
24
24
},
25
25
"devDependencies" : {
26
26
"@theia/cli" : " next"
Original file line number Diff line number Diff line change 1
1
{
2
2
"private" : true ,
3
3
"name" : " electron-app" ,
4
- "version" : " 0.0.7 " ,
4
+ "version" : " 0.1.0 " ,
5
5
"license" : " MIT" ,
6
6
"main" : " src-gen/frontend/electron-main.js" ,
7
7
"dependencies" : {
21
21
"@theia/process" : " next" ,
22
22
"@theia/terminal" : " next" ,
23
23
"@theia/workspace" : " next" ,
24
- "arduino-ide-extension" : " 0.0.7 " ,
25
- "arduino-debugger-extension" : " 0.0.7 "
24
+ "arduino-ide-extension" : " 0.1.0 " ,
25
+ "arduino-debugger-extension" : " 0.1.0 "
26
26
},
27
27
"devDependencies" : {
28
28
"@theia/cli" : " next"
Original file line number Diff line number Diff line change 1
1
{
2
2
"name" : " arduino-editor" ,
3
- "version" : " 0.0.7 " ,
3
+ "version" : " 0.1.0 " ,
4
4
"description" : " Arduino Pro IDE" ,
5
5
"repository" : " https://github.com/bcmi-labs/arduino-editor.git" ,
6
6
"author" : " Arduino SA" ,
You can’t perform that action at this time.
0 commit comments