Run e2e tests only with GUI version on macos (Github runners are basically mac mini with GUI support)"

Author: umbynos

.github/workflows/release.yml

@@ -128,13 +128,13 @@ jobs:
         with:
           python-version: '3.9'
           architecture: 'x64'
-        if: matrix.os == 'ubuntu-18.04'
+        if: matrix.os == 'macos-10.15'
 
       - name: Run e2e tests
         run: |
           pip install poetry
           task test-e2e
-        if: matrix.os == 'ubuntu-18.04'
+        if: matrix.os == 'macos-10.15'
 
         # this will create `public/` dir with compressed full bin (<version>/<os>-<arch>.gz) and a json file
       - name: Create autoupdate files

.github/workflows/test.yml

@@ -96,13 +96,13 @@ jobs:
         with:
           python-version: '3.9'
           architecture: 'x64'
-        if: matrix.os == 'ubuntu-18.04'
+        if: matrix.os == 'macos-10.15'
 
       - name: Run e2e tests
         run: |
           pip install poetry
           task test-e2e
-        if: matrix.os == 'ubuntu-18.04'
+        if: matrix.os == 'macos-10.15'
 
         # config.ini is required by the executable when it's run
       - name: Upload artifacts

test/conftest.py

@@ -12,7 +12,7 @@
 @pytest.fixture(scope="function")
 def agent(pytestconfig):
 
-    agent_cli = str(Path(pytestconfig.rootdir) / "arduino-create-agent_cli")
+    agent_cli = str(Path(pytestconfig.rootdir) / "arduino-create-agent")
     env = {
         # "ARDUINO_DATA_DIR": data_dir,
         # "ARDUINO_DOWNLOADS_DIR": downloads_dir,
@@ -24,7 +24,7 @@ def agent(pytestconfig):
 
     cd_command = "cd"
     with run_context.prefix(f'{cd_command} ..'):
-        runner.run(command=agent_cli, echo=True, hide=True, warn=True, env=env, asynchronous=True)
+        runner.run(agent_cli, echo=True, hide=True, warn=True, env=env, asynchronous=True)
 
         # we give some time to the agent to start and listen to
         # incoming requests