Sligltly simplified getDefaultConfigDir

Author: cmaglie

config.go

@@ -17,15 +17,14 @@ package main
 
 import (
 	_ "embed"
-	"fmt"
 	"os"
 
 	"github.com/arduino/go-paths-helper"
 	log "github.com/sirupsen/logrus"
 )
 
-// getDefaultArduinoCreateConfigDir returns the full path to the default arduino create agent data directory
-func getDefaultArduinoCreateConfigDir() (*paths.Path, error) {
+// getDefaultConfigDir returns the full path to the default Arduino Create Agent configuration directory.
+func getDefaultConfigDir() *paths.Path {
 	// UserConfigDir returns the default root directory to use
 	// for user-specific configuration data. Users should create
 	// their own application-specific subdirectory within this
@@ -43,14 +42,14 @@ func getDefaultArduinoCreateConfigDir() (*paths.Path, error) {
 	// is not defined), then it will return an error.
 	configDir, err := os.UserConfigDir()
 	if err != nil {
-		return nil, err
+		log.Panicf("Can't get user home dir: %s", err)
 	}
 
 	agentConfigDir := paths.New(configDir, "ArduinoCreateAgent")
 	if err := agentConfigDir.MkdirAll(); err != nil {
-		return nil, fmt.Errorf("cannot create config dir: %s", err)
+		log.Panicf("Can't create config dir: %s", err)
 	}
-	return agentConfigDir, nil
+	return agentConfigDir
 }
 
 //go:embed config.ini

main.go

@@ -136,10 +136,7 @@ func main() {
 	go loop()
 
 	// SetupSystray is the main thread
-	configDir, err := getDefaultArduinoCreateConfigDir()
-	if err != nil {
-		log.Panicf("Can't open defaul configuration dir: %s", err)
-	}
+	configDir := getDefaultConfigDir()
 	Systray = systray.Systray{
 		Hibernate: *hibernate,
 		Version:   version + "-" + commit,
@@ -201,7 +198,7 @@ func loop() {
 	src, _ := os.Executable()
 	srcPath := paths.New(src)  // The path of the agent's binary
 	srcDir := srcPath.Parent() // The directory of the agent's binary
-	agentDir, err := getDefaultArduinoCreateConfigDir()
+	agentDir := getDefaultConfigDir()
 
 	// Instantiate Tools
 	Tools = tools.Tools{
@@ -216,6 +213,7 @@ func loop() {
 	Tools.Init(requiredToolsAPILevel)
 
 	// Let's handle the config
+	configDir := getDefaultConfigDir()
 	var configPath *paths.Path
 
 	// see if the env var is defined, if it is take the config from there, this will override the default path
@@ -225,7 +223,7 @@ func loop() {
 			log.Panicf("config from env var %s does not exists", envConfig)
 		}
 		log.Infof("using config from env variable: %s", configPath)
-	} else if defaultConfigPath := agentDir.Join("config.ini"); defaultConfigPath.Exist() {
+	} else if defaultConfigPath := configDir.Join("config.ini"); defaultConfigPath.Exist() {
 		// by default take the config from the ~/.arduino-create/config.ini file
 		configPath = defaultConfigPath
 		log.Infof("using config from default: %s", configPath)
@@ -243,7 +241,7 @@ func loop() {
 		}
 	}
 	if configPath == nil {
-		configPath = generateConfig(agentDir)
+		configPath = generateConfig(configDir)
 	}
 
 	// Parse the config.ini