Skip to content

Commit 2a3e6f1

Browse files
committed
revert install rsrc in a separate step: should solve not found in PATH
1 parent 069598d commit 2a3e6f1

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ jobs:
6363
run: task build-cli
6464
if: matrix.operating-system == 'ubuntu-18.04'
6565

66+
# the manifest is required by windows GUI apps, otherwise the binary will crash with: "Unable to create main window: TTM_ADDTOOL failed" (for reference https://github.com/lxn/walk/issues/28)
67+
# rsrc will produce a *.syso file that should get automatically recognized by go build command and linked into an executable.
68+
- name: Download tool to embed manifest in win binary
69+
run: go get github.com/akavel/rsrc
70+
if: matrix.operating-system == 'windows-2019'
71+
6672
# building the agent for win requires a different task because of an extra flag
6773
- name: Build the Agent for win32
6874
env:

.github/workflows/test.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@ jobs:
5858
run: task build-cli
5959
if: matrix.operating-system == 'ubuntu-18.04'
6060

61+
# the manifest is required by windows GUI apps, otherwise the binary will crash with: "Unable to create main window: TTM_ADDTOOL failed" (for reference https://github.com/lxn/walk/issues/28)
62+
# rsrc will produce a *.syso file that should get automatically recognized by go build command and linked into an executable.
63+
- name: Download tool to embed manifest in win binary
64+
run: go get github.com/akavel/rsrc
65+
if: matrix.operating-system == 'windows-2019'
66+
6167
# building the agent for win requires a different task because of an extra flag
6268
- name: Build the Agent for win32
6369
env:

Taskfile.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ tasks:
2121
build-win:
2222
desc: Build the project for win, to build 32bit `export GOARCH=386` and for 64 bit `export GOARCH=amd64` before `task build-win`
2323
cmds:
24-
# the manifest is required by windows GUI apps, otherwise the binary will crash with: "Unable to create main window: TTM_ADDTOOL failed" (for reference https://github.com/lxn/walk/issues/28)
25-
- go get github.com/akavel/rsrc
26-
# rsrc will produce a *.syso file that should get automatically recognized by go build command and linked into an executable.
2724
- rsrc -arch {{.GOARCH}} -manifest manifest.xml # GOARCH shoud be either amd64 or 386
2825
- task: build
2926
vars:

0 commit comments

Comments
 (0)