Skip to content

Git-ignore the arduino-cli.exe on Windows. #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

kittaakos
Copy link
Contributor

When I build the CLI on Windows, I do not want to see the executable as
an outgoing Git change. Same as on POSIX.

Running git check-ignore -v arduino-cli on macOS shows which line is used to ignore the executable:

.gitignore:2:/arduino-cli	arduino-cli

This PR adjusts the .gitignore file, to improve the contributing experience for Windows devs.

Signed-off-by: Akos Kitta kittaakos@typefox.io

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Feature.

  • What is the current behavior?

When I run go build on Windows, I have a git outgoing change.

  • What is the new behavior?

After building the CLI from the sources, and running git status -s it returns with nothing. Previously, it was:

git status -s
?? arduino-cli.exe
  • Does this PR introduce a breaking change?

No.

  • Other information:

See how to contribute

When I build the CLI on Windows, I do not want to see the executable as
an outgoing Git change. Same as on POSIX.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@rsora rsora merged commit 28c872c into arduino:master Aug 19, 2020
@kittaakos kittaakos deleted the ignore-executable-on-windows branch August 19, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants