From 36102d4a8c3f0bce42735eed146b61ff31a7d025 Mon Sep 17 00:00:00 2001 From: Massimiliano Pippi Date: Tue, 22 Oct 2019 12:40:46 +0200 Subject: [PATCH 1/4] run tests on osx --- .github/workflows/test.yaml | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index d592b8a9bed..9c6c517aff8 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -1,13 +1,17 @@ name: test -on: [push, pull_request] +on: + push: + branches: + - master + pull_request: jobs: test-matrix: strategy: matrix: - operating-system: [ubuntu-18.04, windows-2019] + operating-system: [ubuntu-18.04, windows-2019, macOS-10.14] runs-on: ${{ matrix.operating-system }} @@ -48,7 +52,8 @@ jobs: run: task test-unit - name: Run unit tests on the legacy package - if: matrix.operating-system != 'windows-2019' + # Run legacy tests on one platform only + if: matrix.operating-system == 'ubuntu-18.04' run: task test-legacy - name: Install Python @@ -68,7 +73,7 @@ jobs: # Codecov whitelists GitHub, lifting the need # for a token. if: > - matrix.operating-system != 'windows-2019' && + matrix.operating-system == 'ubuntu-18.04' && github.event_name == 'push' uses: codecov/codecov-action@v1.0.2 with: @@ -82,7 +87,7 @@ jobs: # Codecov whitelists GitHub, lifting the need # for a token. if: > - matrix.operating-system != 'windows-2019' && + matrix.operating-system == 'ubuntu-18.04' && github.event_name == 'push' uses: codecov/codecov-action@v1.0.2 with: @@ -96,7 +101,7 @@ jobs: # Codecov whitelists GitHub, lifting the need # for a token. if: > - matrix.operating-system != 'windows-2019' && + matrix.operating-system == 'ubuntu-18.04' && github.event_name == 'push' uses: codecov/codecov-action@v1.0.2 with: From ade2780402e4d5987d817cc7a80d9649578c18cd Mon Sep 17 00:00:00 2001 From: Massimiliano Pippi Date: Tue, 22 Oct 2019 15:03:12 +0200 Subject: [PATCH 2/4] use latest version of the action --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 9c6c517aff8..df237c0a8e4 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -40,7 +40,7 @@ jobs: run: task check - name: Install protoc compiler - uses: Arduino/actions/setup-protoc@master + uses: arduino/setup-protoc@v1.0.0 - name: Check protocol buffers compile correctly run: task protoc From 97d1b495bcc2ae607321a0bba3f0e2555d0e7017 Mon Sep 17 00:00:00 2001 From: Massimiliano Pippi Date: Tue, 22 Oct 2019 17:10:33 +0200 Subject: [PATCH 3/4] bump to 1.1.0 --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index df237c0a8e4..f25d88204f7 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -40,7 +40,7 @@ jobs: run: task check - name: Install protoc compiler - uses: arduino/setup-protoc@v1.0.0 + uses: arduino/setup-protoc@v1.1.0 - name: Check protocol buffers compile correctly run: task protoc From 1817eab80ab444c44c45716bb5119a7b62d5b2b5 Mon Sep 17 00:00:00 2001 From: Massimiliano Pippi Date: Tue, 22 Oct 2019 17:11:57 +0200 Subject: [PATCH 4/4] pass github token --- .github/workflows/test.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index f25d88204f7..076f70f4f06 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -41,6 +41,8 @@ jobs: - name: Install protoc compiler uses: arduino/setup-protoc@v1.1.0 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} - name: Check protocol buffers compile correctly run: task protoc