Skip to content

[skip changelog] Update broken or outdated links #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2022
Merged

[skip changelog] Update broken or outdated links #1833

merged 3 commits into from
Aug 11, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 11, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • [N/A] UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Documentation fix

What is the current behavior?

Some of the links in the documentation are broken (in ways or forms that are not covered by the automated link check).

Some of the links in the documentation rely on redirects which could break in the future.

What is the new behavior?

All links in documentation reach their intended target, and reach it directly.

Does this PR introduce a breaking change

No breaking change.

Other information

Fixes #1832

Parts of the documentation use reference links, where the inline markup uses a label, which matches to a link reference
definition elsewhere in the documentation.

The major disadvantage of this approach is that unused link reference definitions are often left behind after the
referencing text is removed, cluttering up the documentation and increasing the maintenance burden. That was the case
here.

The unused link reference definitions are hereby removed.
Some of the documentation links no longer reached their intended target.

These were not caught by the Markdown link check for one of two reasons:

- Redirects to a useless generic page instead of the moved specific target page
- Links in non-Markdown files
Some of the links in the documentation used URLs that were redirecting to the new location of the target page.

Even though these links still took the reader to the intended place eventually, it is safest to not rely on them
continuing to work for the long term, so is best to update to point directly to the target.
@per1234 per1234 added topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project labels Aug 11, 2022
@per1234 per1234 self-assigned this Aug 11, 2022
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Per, good job!

@per1234 per1234 merged commit 513f5a1 into arduino:master Aug 11, 2022
cmaglie pushed a commit to cmaglie/arduino-cli that referenced this pull request Aug 22, 2022
* [skip changelog] Remove unused link reference definitions in docs

Parts of the documentation use reference links, where the inline markup uses a label, which matches to a link reference
definition elsewhere in the documentation.

The major disadvantage of this approach is that unused link reference definitions are often left behind after the
referencing text is removed, cluttering up the documentation and increasing the maintenance burden. That was the case
here.

The unused link reference definitions are hereby removed.

* [skip changelog] Fix broken links in documentation

Some of the documentation links no longer reached their intended target.

These were not caught by the Markdown link check for one of two reasons:

- Redirects to a useless generic page instead of the moved specific target page
- Links in non-Markdown files

* [skip changelog] Update documentation links that depend on redirects

Some of the links in the documentation used URLs that were redirecting to the new location of the target page.

Even though these links still took the reader to the intended place eventually, it is safest to not rely on them
continuing to work for the long term, so is best to update to point directly to the target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in library specifications
2 participants