Skip to content

[breaking] Refactor errors handling in packagemanager.Load* methods #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2022
Merged

[breaking] Refactor errors handling in packagemanager.Load* methods #1682

merged 3 commits into from
Mar 3, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 3, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
Replace *status.Status with errors in packagemanager.Load* functions

What is the current behavior?
The CLI behaviour is unchanged.

Does this PR introduce a breaking change, and is titled accordingly?
The breaking change is in the golang API of packagamanager module, as documented in UPGRADING.md.

@cmaglie cmaglie requested a review from a team March 3, 2022 15:41
@cmaglie cmaglie merged commit a478b4a into arduino:master Mar 3, 2022
@cmaglie cmaglie deleted the refactor-load-errors branch March 3, 2022 18:33
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @silvanocerza @per1234