Skip to content

Fix UTF8 filenames not being matched by gcc -e output parsing (round 2) #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2016
Merged

Fix UTF8 filenames not being matched by gcc -e output parsing (round 2) #195

merged 2 commits into from
Nov 23, 2016

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 23, 2016

Supersedes #178

/cc @facchinm

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-195.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

facchinm and others added 2 commits November 23, 2016 12:37
@facchinm @cmaglie
Add tests to handle utf8 paths
aaab313 
Signed-off-by: Martino Facchin <m.facchin@arduino.cc>
@cmaglie
Treat cpp string as UTF8
4641067 
Fix arduino/Arduino#5277

Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
@facchinm facchinm merged commit 29e9297 into arduino:master Nov 23, 2016
@facchinm facchinm mentioned this pull request Nov 23, 2016
Closed
@cmaglie cmaglie deleted the fix-utf8 branch November 23, 2016 11:40
@matthijskooijman
Copy link
Collaborator

Looks good to me!

@cmaglie cmaglie modified the milestone: 1.3.22 Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.22
Development

Successfully merging this pull request may close these issues.
4 participants
@cmaglie @ArduinoBot @matthijskooijman @facchinm