Fix compilation of a library that contains a "utility" file #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libraries can contain a "utility" directory, which is then added to the include path and whose contents are compiled. However, the code that handled this only checked for existence of the "utility" path, not if it was actually a directory. If a file with that name existed, it would be treated as a directory, breaking the build. This happens for example with the StandardCplusplus library. Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libraries can contain a "utility" directory, which is then added to the
include path and whose contents are compiled. However, the code that
handled this only checked for existence of the "utility" path, not if it
was actually a directory. If a file with that name existed, it would be
treated as a directory, breaking the build. This happens for example
with the StandardCplusplus library.
Signed-off-by: Matthijs Kooijman matthijs@stdin.nl