Improve include resolution fix for older compilers #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary way to detect includes is to scan the compiler error output for "#include" lines. However, older gcc versions did not print the error line itself, only a message about the error, which would not be detected. In bd5d3ec (Fix include resolution for older compilers), a fallback was added to scan for "fatal error" followed by the missing include filename, but that fallback only looked at the first line of the error output. When the missing #include line is not in the source file being compiled, but in an included file, the error message would something like this: In file included from binouts.ino:52:0: regtable.h:31:22: fatal error: register.h: No such file or directory So the filename that should be found is in the second line (or further). This commit changes the fallback process to keep scanning lines of compiler output, until one is found, instead of only looking at the first line. This fixes arduino#97. Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary way to detect includes is to scan the compiler error output
for "#include" lines. However, older gcc versions did not print the
error line itself, only a message about the error, which would not be
detected. In bd5d3ec (Fix include resolution for older compilers), a
fallback was added to scan for "fatal error" followed by the missing
include filename, but that fallback only looked at the first line of the
error output.
When the missing #include line is not in the source file being compiled,
but in an included file, the error message would something like this:
So the filename that should be found is in the second line (or further).
This commit changes the fallback process to keep scanning lines of
compiler output, until one is found, instead of only looking at the
first line.
This fixes #97.
Signed-off-by: Matthijs Kooijman matthijs@stdin.nl