Show stdout of preproc commands in verbose mode

matthijskooijman · cmaglie · commit 79afcb609fb6 · 2018-01-10T19:02:32.000+01:00
This also happens with the normal compilation commands, so why not with
these? Normally these commands should not output to stdout, so this
doesn't make any difference, but it makes things more consistent.

Signed-off-by: Matthijs Kooijman &lt;matthijs@stdin.nl&gt;
diff --git a/gcc_preproc_runner.go b/gcc_preproc_runner.go
@@ -53,7 +53,7 @@ func GCCPreprocRunner(ctx *types.Context, sourceFilePath string, targetFilePath
 
 	verbose := ctx.Verbose
 	logger := ctx.GetLogger()
-	_, err = builder_utils.ExecRecipe(properties, constants.RECIPE_PREPROC_MACROS, true, verbose, false, logger)
+	_, err = builder_utils.ExecRecipe(properties, constants.RECIPE_PREPROC_MACROS, true, verbose, verbose, logger)
 	if err != nil {
 		return i18n.WrapError(err)
 	}
@@ -75,7 +75,7 @@ func GCCPreprocRunnerForDiscoveringIncludes(ctx *types.Context, sourceFilePath s
 		properties[constants.RECIPE_PREPROC_MACROS] = GeneratePreprocPatternFromCompile(properties[constants.RECIPE_CPP_PATTERN])
 	}
 
-	stderr, err := builder_utils.ExecRecipeCollectStdErr(properties, constants.RECIPE_PREPROC_MACROS, true, verbose, false, logger)
+	stderr, err := builder_utils.ExecRecipeCollectStdErr(properties, constants.RECIPE_PREPROC_MACROS, true, verbose, verbose, logger)
 	if err != nil {
 		return "", i18n.WrapError(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func GCCPreprocRunner(ctx *types.Context, sourceFilePath string, targetFilePath`
`53`	`53`
`54`	`54`	`verbose := ctx.Verbose`
`55`	`55`	`logger := ctx.GetLogger()`
`56`		`- _, err = builder_utils.ExecRecipe(properties, constants.RECIPE_PREPROC_MACROS, true, verbose, false, logger)`
	`56`	`+ _, err = builder_utils.ExecRecipe(properties, constants.RECIPE_PREPROC_MACROS, true, verbose, verbose, logger)`
`57`	`57`	`if err != nil {`
`58`	`58`	`return i18n.WrapError(err)`
`59`	`59`	`}`
`@@ -75,7 +75,7 @@ func GCCPreprocRunnerForDiscoveringIncludes(ctx *types.Context, sourceFilePath s`
`75`	`75`	`properties[constants.RECIPE_PREPROC_MACROS] = GeneratePreprocPatternFromCompile(properties[constants.RECIPE_CPP_PATTERN])`
`76`	`76`	`}`
`77`	`77`
`78`		`- stderr, err := builder_utils.ExecRecipeCollectStdErr(properties, constants.RECIPE_PREPROC_MACROS, true, verbose, false, logger)`
	`78`	`+ stderr, err := builder_utils.ExecRecipeCollectStdErr(properties, constants.RECIPE_PREPROC_MACROS, true, verbose, verbose, logger)`
`79`	`79`	`if err != nil {`
`80`	`80`	`return "", i18n.WrapError(err)`
`81`	`81`	`}`