From ced8e5bd1ff6915bd1dafd04c4c781e0734d75d9 Mon Sep 17 00:00:00 2001 From: pennam Date: Fri, 14 Feb 2025 10:41:34 +0100 Subject: [PATCH 1/5] EspSpiDriver: remove empty unused function --- libraries/ESPhost/src/EspSpiDriver.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/libraries/ESPhost/src/EspSpiDriver.cpp b/libraries/ESPhost/src/EspSpiDriver.cpp index 26b3a4532..5644f6cf3 100644 --- a/libraries/ESPhost/src/EspSpiDriver.cpp +++ b/libraries/ESPhost/src/EspSpiDriver.cpp @@ -124,7 +124,6 @@ static spi_event_t _spi_cb_status = SPI_EVENT_TRANSFER_ABORTED; * ############################# */ static void spi_callback(spi_callback_args_t *p_args); -static void ext_irq_callback(void); /* execute SPI communication, send the content of tx_buffer to ESP32, put the @@ -534,9 +533,3 @@ static void spi_callback(spi_callback_args_t *p_args) { _spi_cb_status = SPI_EVENT_TRANSFER_ABORTED; } } - -/* -------------------------------------------------------------------------- */ -static void ext_irq_callback(void) { -/* -------------------------------------------------------------------------- */ - -} \ No newline at end of file From bb7b0f44b64c44bd161f041ae4a415b924531369 Mon Sep 17 00:00:00 2001 From: pennam Date: Fri, 14 Feb 2025 10:42:09 +0100 Subject: [PATCH 2/5] CMsg: fix ctor initialization order --- libraries/ESPhost/src/CMsg.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libraries/ESPhost/src/CMsg.cpp b/libraries/ESPhost/src/CMsg.cpp index 1b71dac93..66e2055da 100644 --- a/libraries/ESPhost/src/CMsg.cpp +++ b/libraries/ESPhost/src/CMsg.cpp @@ -85,16 +85,16 @@ void CMsg::reset_without_delete() { /* -------------------------------------------------------------------------- */ -CMsg::CMsg() : buf{nullptr}, dim{0}, payload_header{nullptr}, proto_dim{0}, tlv_size(esp_tlv_header_size) { +CMsg::CMsg() : buf{nullptr}, dim{0}, proto_dim{0}, payload_header{nullptr}, tlv_size(esp_tlv_header_size) { } /* -------------------------------------------------------------------------- */ /* -------------------------------------------------------------------------- */ -CMsg::CMsg(uint16_t proto_size, bool use_tlv /*= true*/) : buf{nullptr}, - dim{0}, - payload_header{nullptr}, - proto_dim{proto_size} { +CMsg::CMsg(uint16_t proto_size, bool use_tlv /*= true*/) : buf{nullptr}, + dim{0}, + proto_dim{proto_size}, + payload_header{nullptr} { /* -------------------------------------------------------------------------- */ uint16_t request_size = 0; if(use_tlv) { From 44c347af266564206e34f0a076cde6e2f50f0662 Mon Sep 17 00:00:00 2001 From: pennam Date: Fri, 14 Feb 2025 10:42:36 +0100 Subject: [PATCH 3/5] CMsg: add missing return value to move operator --- libraries/ESPhost/src/CMsg.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/ESPhost/src/CMsg.cpp b/libraries/ESPhost/src/CMsg.cpp index 66e2055da..68ecc037d 100644 --- a/libraries/ESPhost/src/CMsg.cpp +++ b/libraries/ESPhost/src/CMsg.cpp @@ -204,6 +204,7 @@ CMsg& CMsg::operator=(CMsg&& m) { Serial.println(" bad!"); #endif } + return *this; } From c1d6de3eb8e2d9993005a4e26dc110e5cc2f6701 Mon Sep 17 00:00:00 2001 From: pennam Date: Fri, 14 Feb 2025 10:43:00 +0100 Subject: [PATCH 4/5] CMsg: suppress unused variable warning --- libraries/ESPhost/src/CMsg.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/ESPhost/src/CMsg.cpp b/libraries/ESPhost/src/CMsg.cpp index 68ecc037d..b2e0f5297 100644 --- a/libraries/ESPhost/src/CMsg.cpp +++ b/libraries/ESPhost/src/CMsg.cpp @@ -443,6 +443,7 @@ void CMsg::debug_print(const char* title) { /* -------------------------------------------------------------------------- */ bool CMsg::store_rx_buffer(const uint8_t *buffer, uint32_t d) { /* -------------------------------------------------------------------------- */ + (void)d; /* rx_payload_len is TLV + PROTO (tlv can be present or not) */ uint16_t rx_payload_len = verify_payload_header(buffer); From 2a8b191a89ada3900e3eb8b36f42b133c1147921 Mon Sep 17 00:00:00 2001 From: pennam Date: Fri, 14 Feb 2025 10:43:28 +0100 Subject: [PATCH 5/5] CMsg: add missing return value to add_msg --- libraries/ESPhost/src/CMsg.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/ESPhost/src/CMsg.cpp b/libraries/ESPhost/src/CMsg.cpp index b2e0f5297..bc7c71959 100644 --- a/libraries/ESPhost/src/CMsg.cpp +++ b/libraries/ESPhost/src/CMsg.cpp @@ -500,6 +500,7 @@ bool CMsg::add_msg(CMsg &msg) { return false; } } + return true; } /* -------------------------------------------------------------------------- */