Skip to content

Fix compiler warnings about ignored 'const' in EEPROM.h #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

bxparks
Copy link
Contributor

@bxparks bxparks commented Aug 30, 2018

Fix for Issue #36

Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

For future reference, it would have been fine to just create the PR, without also creating a separate issue (especially since the fix is so simple). No worries now, though :-)

@per1234
Copy link
Contributor

per1234 commented Aug 30, 2018

Fixes arduino/Arduino#3783

@facchinm
Copy link
Member

LGTM! Does it solve the issue for both 4.9 (AVR core 1.6.19) and 5.4 (AVR core 1.6.20) compilers?

@bxparks
Copy link
Contributor Author

bxparks commented Sep 1, 2018

@facchinm: Did you mean to ask me that question?

I've only ever used Arduino IDE 1.8.5 (maybe 1.8.4?). As far as I can tell from package_index.json, all 3 of the most recent AVR core versions (1.6.19, 1.6.20, 1.6.21) use the same compiler:

            "toolsDependencies": [
              {
                "packager": "arduino",
              "paname": "avr-gcc",
             "naversion": "4.9.2-atmel3.5.4-arduino2"
              },

We have to go back to 1.6.17 to get to an AVR Core that uses a different compiler (4.9.2-atmel3.5.3-arduino2), and I verified that the bug is there as well and is fixed by this PR.

@per1234
Copy link
Contributor

per1234 commented Sep 1, 2018

@bxparks Arduino IDE 1.8.6's bundled Arduino AVR Boards 1.6.22 uses avr-gcc '5.4.0-atmel3.6.1-arduino2. Arduino AVR Boards 1.6.22 hasn't been released separately from the IDE so that's why you don't see it in https://downloads.arduino.cc/packages/package_index.json. Perhaps facchinm got the version number mixed up.

@bxparks
Copy link
Contributor Author

bxparks commented Sep 2, 2018

Ah, it was released a few days ago.
I installed IDE 1.8.6 and verified my PR fixes the warning in avr-gcc 5.4.0-atmel3.6.1-arduino2 (core 1.6.22) as well.

@facchinm
Copy link
Member

facchinm commented Sep 3, 2018

Yes, I meant 1.6.22, sorry for the confusion.

@cmaglie cmaglie merged commit 6848ea4 into arduino:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants