Skip to content

Initial port of BLEPeripheral style API to CurieBle library #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 64 commits into from
Dec 7, 2015
Merged

Initial port of BLEPeripheral style API to CurieBle library #81

merged 64 commits into from
Dec 7, 2015

Conversation

sandeepmistry
Copy link
Contributor

Initial port of the BLEPeripheral API to the CurieBle library.

Changes also include:

  • Internal updates to allow for no limit on the number of services, characteristics, and descriptors that can be added to the peripheral.
  • The buffers used for characteristic and descriptor values are not dynamically allocated.
  • keywords.txt file added for syntax highlighting support in the Arduino IDE.

Example updates:

  • BatteryMonitor updated to Arduino example style
  • Added 3 new LED based examples (LED, LED callback, LED with button)
  • AutomationIO example has been removed as it was to complex of an example for the targeted user base. The new LED examples cover how to achieve the same goal with a single pin.

Notes:

  • There is no services changed characteristic, so iOS will cache previous services and characteristics when they change in a sketch upload. Turning Bluetooth off and then back on again in iOS clears the cache. I believe a fix for this is needed on the firmware side. (This was already an issue with the previous version of the library).
  • Some of the BLEPeripheral API's have not been ported over as they will require support on the nRF firmware. They can be added in a later release.

cc/ @tigoe @hbisby @facchinm

@sandeepmistry
Add CurieBle.h for main lib header
7eea01f
@sandeepmistry
Rename BleDevice.* files to BlePeripheral.*
e8bdd87
@sandeepmistry
Initial keywords.txt
08fd946
@sandeepmistry
Rename bleDevice variable to blePeripheral
6d5aa27
@sandeepmistry
Add begin and end API's
60f6c47
@sandeepmistry
Add poll API (no-op for now)
ff11e02
@sandeepmistry
Rename set/getName to set/getLocalName
e7b71f5
@sandeepmistry
Add uuid method to BleService
2881aa5
@sandeepmistry
Add setAdvertisedServiceUuid API, and remove param to advertise from …
4e2a4d7 
…addPrimaryService
@sandeepmistry
Add BleCentral class, disconnect API, split out BleAddress
dbdebdb
@sandeepmistry
More keywords
bf3d0bb
@sandeepmistry
Split up GAP event callback registration
6d101d6
@sandeepmistry
Expose characteristic properties instead of access and notify mode
e136ce8
@sandeepmistry
Add BleAttibute class and add new public addAttribute API
a1d134b 
Make addPrimaryService and getState API’s private. As well as,
BleService::addCharacteristic, BleService::addSecondaryService, and
BleCharacateristic::addDescriptor.
@sandeepmistry
Change begin to return BleStatus
67d47f3
@sandeepmistry
Introduce BleUuid, UUID's are now strings externally
b06df63
@sandeepmistry
Allow BleCharacteristic::setValue to be called before begin
a711fa2
@sandeepmistry
Whitespace formatting
2fb5614
@sandeepmistry
Change return type of BleCentrall::address a C string, make getLocalA…
be1fcea 
…ddress private for now
@sandeepmistry
Add typed characteristics
69697e3
@sandeepmistry
BlePeripheral event handler rename, and misc var name consistency
e01b7bf
@sandeepmistry
More keyword.txt updates
06a05c2
@sandeepmistry
Make descriptor BleCharacteristic API's private
d4efbb2
@sandeepmistry
BleCharacteristic event handler API's
99ab222
@sandeepmistry
Experimental BatteryMonitor example sketch with new API
4dfc0a4
@sandeepmistry
Reverse UUID conversion loop
3d3f65f
@sandeepmistry
Update previousMillis in example
cd54545
@sandeepmistry
Add written and subscribed API's to BleCharacteristic, pass central i…
6e5a9de 
…nto BleCharacteristic even handers, remove BleAck event for now
@sandeepmistry
Add new LED example
03c82d3
@sandeepmistry
API Cleanup
2581cff
sandeepmistry and others added 27 commits December 4, 2015 12:14
@sandeepmistry
Change internals to use less private friends, add comments in header …
855737b 
…files, make var types more consistent
@sandeepmistry
keywords.txt updates
1b4f513
@sandeepmistry
Add delay(1) in poll
e0139b6
@hbisby @sandeepmistry
variable name changed from switchCharacteristic to ledCharacteristic
8ee6a02
@sandeepmistry
Add special handling for 0x2902 and 0x2904 descriptors
c1882ee
@sandeepmistry
Correct presentation format descriptor handling
fe78397
@sandeepmistry
Correct advertised service uuid
661fc89
@sandeepmistry
Don't advertise the device appearence
c236092
@sandeepmistry
Separate device name from advertised local name
ee0ae44
@sandeepmistry
Rename Ble prefixes to BLE
7767d3d
@sandeepmistry
Replace battery monitor example with new version
026f4c0
@sandeepmistry
Change public API types to use non-stdint types
1596dc1 
as per https://www.arduino.cc/en/Reference/HomePage
@sandeepmistry
Use bool for public API's return types instead of BleStatus type
b6eea74
@sandeepmistry
Remove while(!Serial)
ce32c92
@sandeepmistry
Set initial value of switch characateristic
6d6a0c6
@sandeepmistry
Sent initial value of switch characteristic
479e860
@sandeepmistry
Set initial value of characteristics
040b63b
@sandeepmistry
Dynamically allocate characteristic and descriptor data buffers
c692433
@sandeepmistry
Correct incorrect read permissions for non-writable characteristics
a5c7f84
@tigoe @sandeepmistry
Style changes to BLE library examples
3b8efcc
@sandeepmistry
Remove AutomationIO example
3c84824
@sandeepmistry
Correct setDeviceName
ccfaa83
@sandeepmistry
Correct case of include
93ce2bb
@sandeepmistry
Misc example updates
b272315
@sandeepmistry
Update note on local name
44cd7e5
@sandeepmistry
Shorten local name in examples
744e66e
@tigoe
Style changes to IMU examples
956aac4 
Note: IMU Library API still needs to be standardized.
@bigdinotech
Copy link
Contributor

@sandeepmistry looks great thanks!
@calvinatintel please merge

calvinatintel added a commit that referenced this pull request Dec 7, 2015
@calvinatintel
Merge pull request #81 from sandeepmistry/arduino-ble-peripheral-api
51c7f7d 
Initial port of BLEPeripheral style API to CurieBle library
@calvinatintel calvinatintel merged commit 51c7f7d into arduino:master Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sandeepmistry @bigdinotech @tigoe @soundanalogous @calvinatintel @hbisby