Fixes to pass validation with test suite #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to pass C++ validation in test suite
|
@SidLeung @kmsywula @intel-larry Please review |
Test suite failed on these functions
the Serial via USB port is not a real virtual cdc port (it still emulates an Hardware Serial), remove to avoid sketches getting confused and expect CDC flow control functions
needed to pass a very strict test Porting of latest Due implementation
facchinm
changed the title
|
I've added two more commits to address issues emerged with recently added tests. |
|
@SidLeung @kmsywula @bigdinotech Please review |
|
@calvinatintel looks good to me. +1 |
calvinatintel
added a commit
that referenced
this pull request
Oct 29, 2015
Fixes to pass validation with test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to pass C++ validation in test suite