Ensure RTC clock scaling is set to 1Hz #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eriknyquist @SidLeung ready for review |
eriknyquist
suggested changes
Nov 29, 2016
|
|
||
|
|
||
| //set RTC clock divider to 32768 | ||
| *SYS_CLK_CTL |= 0x00000078; |
There was a problem hiding this comment.
Use some #defines with human-readable names, please. I'd rather not have to look up the hardware
spec in order to learn what each line is doing. Same goes for all the magic numbers here.
-needed to make sure that the RTC scaling is consitent with the factory firmware and CODK-M based firmware
|
requested changes made |
eriknyquist
approved these changes
Dec 1, 2016
|
@calvinatintel please merge the Jenkins merger seems to be failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-needed to make sure that the RTC scaling is consitent with the factory
firmware and CODK-M based firmware