Skip to content

Commit 65b1874

Browse files
Apply suggestions from code review from @per1234
Co-Authored-By: sandeepmistry <sandeep.mistry@gmail.com>
1 parent d1b971a commit 65b1874

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

examples/Google Cloud Platform IoT Core/GCP_IoT_Core_GSM/GCP_IoT_Core_GSM.ino

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
88
It publishes a message every 5 seconds to "/devices/{deviceId}/state" topic
99
and subscribes to messages on the "/devices/{deviceId}/config" and
10-
"/devices/{deviceId}/commands/# topics.
10+
"/devices/{deviceId}/commands/#" topics.
1111
1212
The circuit:
1313
- MKR GSM 1400 board
@@ -107,7 +107,7 @@ void connectGSM() {
107107
}
108108

109109
void connectMQTT() {
110-
Serial.print("Attempting to MQTT broker: ");
110+
Serial.print("Attempting to connect to MQTT broker: ");
111111
Serial.print(broker);
112112
Serial.println(" ");
113113

examples/Google Cloud Platform IoT Core/GCP_IoT_Core_GSM/arduino_secrets.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// GSM settings
22
#define SECRET_PINNUMBER ""
3-
#define SECRET_GPRS_APN "GPRS_APN" // replace your GPRS APN
3+
#define SECRET_GPRS_APN "GPRS_APN" // replace with your GPRS APN
44
#define SECRET_GPRS_LOGIN "login" // replace with your GPRS login
55
#define SECRET_GPRS_PASSWORD "password" // replace with your GPRS password
66

examples/Google Cloud Platform IoT Core/GCP_IoT_Core_NB/GCP_IoT_Core_NB.ino

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
88
It publishes a message every 5 seconds to "/devices/{deviceId}/state" topic
99
and subscribes to messages on the "/devices/{deviceId}/config" and
10-
"/devices/{deviceId}/commands/# topics.
10+
"/devices/{deviceId}/commands/#" topics.
1111
1212
The circuit:
1313
- MKR NB 1500 board
@@ -104,7 +104,7 @@ void connectNB() {
104104
}
105105

106106
void connectMQTT() {
107-
Serial.print("Attempting to MQTT broker: ");
107+
Serial.print("Attempting to connect to MQTT broker: ");
108108
Serial.print(broker);
109109
Serial.println(" ");
110110

examples/Google Cloud Platform IoT Core/GCP_IoT_Core_WiFi/GCP_IoT_Core_WiFi.ino

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
88
It publishes a message every 5 seconds to "/devices/{deviceId}/state" topic
99
and subscribes to messages on the "/devices/{deviceId}/config" and
10-
"/devices/{deviceId}/commands/# topics.
10+
"/devices/{deviceId}/commands/#" topics.
1111
1212
The circuit:
1313
- Arduino MKR WiFi 1010 or MKR1000
@@ -101,7 +101,7 @@ void connectWiFi() {
101101
}
102102

103103
void connectMQTT() {
104-
Serial.print("Attempting to MQTT broker: ");
104+
Serial.print("Attempting to connect to MQTT broker: ");
105105
Serial.print(broker);
106106
Serial.println(" ");
107107

0 commit comments

Comments
 (0)