Skip to content

Improve accessibility in the Preferences dialog #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

coreyknapp
Copy link
Contributor

This commit makes the Preferences dialog more usable by accessibility devices like screen readers.

Previously, a screen reader would only read the content of the text boxes. By using JLabel's setLabelFor() feature (and in some extreme cases, setAccessibleName()), a screen reader will know that a label is assigned to a text field. For example, instead of just reading "12", it will now read "Editor font size: 12".

This commit makes the Preferences dialog more usable by accessibility devices like screen readers.

Previously, a screen reader would only read the content of the text boxes. By using JLabel's setLabelFor() feature (and in some extreme cases, setAccessibleName()), a screen reader will know that a label is assigned to a text field. For example, instead of just reading "12", it will now read "Editor font size: 12".
@facchinm
Copy link
Member

I absolutely LOVE this kind of contributions. Thank you very very much @coreyknapp .
If you could help us in finding the remaining inaccessible parts of the IDE (I bet there are a lot) it would be incredibly useful. Thanks again!

@facchinm facchinm modified the milestones: Release 1.8.6, Next Nov 10, 2017
@coreyknapp
Copy link
Contributor Author

I actually have a few more updates planned, this was just low-hanging fruit that I could go ahead and knock out.

As of right now, the biggest accessibility obstacle is with the Board and Library Managers. There's two problems: The screen reader can't read what's inside the table cells, and the buttons inside the table cells cannot be accessed with the keyboard. I can fix the first problem pretty easily by taking advantage of Swing's accessibility tools but the second problem is rooted in how the table is being rendered. I don't think there's an easy solution.

@facchinm facchinm merged commit cd9a15e into arduino:master Nov 13, 2017
@facchinm
Copy link
Member

Got it! Thank you very much for the effort. Let us know if there is anything we can do on the Board/Lib manager UI side to ease your development!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants