Auto format : indent namespaces by default #6813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijskooijman
approved these changes
Oct 11, 2017
facchinm
approved these changes
Oct 11, 2017
facchinm
added
the
Component: IDE user interface
facchinm
added
Component: IDE
|
It's pretty typical not to indent namespaces in C++ code, because typically the entire contents of a file is within a single namespace. The google style guide also recommends against indenting namespaces. |
|
I agree with @eric-wieser here, it seems more common to not indent namespaces. Anyway, we will never find a configuration that match everyone's personal taste, so I'll close this as wontfix and just keep the existing configuration. |
cmaglie
added
the
Type: Wontfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO, namespaces should be indented by default. It would be interesting to see if it was decided (per some guideline) not to indent namespaces or if it was just forgotten.
closes #6812