Skip to content

Only rescan libraries folders when really needed #6419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Only rescan libraries folders when really needed #6419

wants to merge 3 commits into from

Conversation

facchinm
Copy link
Member

Scanning libraries is an heavy task if the sketchbook becomes huge;
This patch targets two points:

  • remove the rescan() after setLibrariesFolders(), which already performs a rescan
  • call setLibrariesFolders() only when the folder list has changed
    • This ensures that no scan is performed when changing board in the same architecture

Could mitigate #6350

@arduino arduino deleted a comment from ArduinoBot Jun 23, 2017
@gilbertoverg gilbertoverg mentioned this pull request Jun 28, 2017
Closed
@facchinm facchinm requested a review from cmaglie July 18, 2017 13:47
@facchinm facchinm added this to the Release 1.8.4 milestone Jul 18, 2017
@facchinm facchinm modified the milestones: Release 1.8.4, Next Aug 18, 2017
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-717-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-717-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-717-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-717-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-717-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@arduino arduino deleted a comment from ArduinoBot Sep 15, 2017
facchinm and others added 3 commits January 26, 2018 17:04
@facchinm @cmaglie
Only rescan libraries folders when really needed
b813156 
Scanning libraries is an heavy task if the sketchbook becomes huge;
This patch targets two points:

- remove the rescan() after setLibrariesFolders(), which already performs a rescan
- call setLibrariesFolders() only when the folder list has changed
  - This ensures that no scan is performed when changing board in the same architecture

Could mitigate arduino#6350
@cmaglie
Use List instead of ArrayList where possible
234c19f
@cmaglie
Move the check into setLibrariesFolders()
f2595d0
@cmaglie cmaglie force-pushed the rescan_libs_when_necessary branch from e19e6bc to f2595d0 Compare February 2, 2018 13:49
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-743-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-743-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-743-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-743-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6419-BUILD-743-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@cmaglie
Copy link
Member

cmaglie commented May 3, 2018

Manually merged.

@cmaglie cmaglie closed this May 3, 2018
@cmaglie cmaglie deleted the rescan_libs_when_necessary branch May 3, 2018 13:32
@cmaglie cmaglie modified the milestones: Next, Release 1.8.6 May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.8.6
Development

Successfully merging this pull request may close these issues.
3 participants
@facchinm @ArduinoBot @cmaglie