cross-platform jni implementation for serial port details discovery #4211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
force-pushed
the
iserial_field
branch
from
65486fe to
c48446a
Compare
facchinm
force-pushed
the
iserial_field
branch
7 times, most recently
from
a2b417e to
c3f9d1b
Compare
serial.port.iserial holds the iSerial value
Solves upload to particularly configured SSH servers which wrongly chooses Kerberos auth method
facchinm
force-pushed
the
iserial_field
branch
from
c3f9d1b to
4041993
Compare
facchinm
force-pushed
the
iserial_field
branch
from
4041993 to
2a677b4
Compare
facchinm
changed the title
facchinm
added a commit
that referenced
this pull request
Jan 7, 2016
cross-platform jni implementation for serial port details discovery
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add iSerial field to serial port VID_PID report it was necessary to extensively patch all platforms.
Take this chance to solve long running problems with
listcomports.exe,system_profilerandudevadmmethods. The new implementation is based on sigrok's libserialportThe jni wrapper is temporarily hosted here
This PR should solve issue #4230 (and possibly others due to the general slowness of calling external tools)
This PR also introduces
{serial.port.iserial}environment variable which can be used inplatform.txt