IDE: prevent multiple 'bad name' notifications. #3122

Chris--A · 2015-05-12T07:10:25Z

This patch will prevent the IDE from informing the user about a bad sketch folder name multiple times. Now the user is informed once at start up only, or once when it is detected during a re-scan of the folders.

Here is a run down of what I have noticed. Being bugged twice by V1.5.7 was fine, but now its a minimum of eight times. This only involves one folder with an invalid name.

Version 1.5.7

twice on start up.
once on board change.
no board manager to compare

Version 1.6.3

eight times on start up.
four on board change.
eight on opening of board manager.
four on closing board manager.

Version 1.6.4

eight times on start up
four on board change
six on board manager open
eight on board manager close.

In 1.6.4 simply starting the IDE, opening/closing the board manager and changing board types generates 26 notification boxes for me to click.

…net instead of switch.dl.sourceforge.net

In my case I had to change it to make my 16x4 LCD work properly Fixes arduino#1333

Add watchdog routines for Due

… case of a hourly build

ffissore · 2015-05-12T07:20:59Z

@ArduinoBot build this please

ArduinoBot · 2015-05-12T08:07:11Z

Build successful. Please test this code using one of the following:
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3122-BUILD-266-linux32.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3122-BUILD-266-linux64.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3122-BUILD-266-windows.zip
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3122-BUILD-266-macosx.zip

Chris--A · 2015-05-12T08:30:07Z

Downloading windows version now, will test it soon.

Chris--A · 2015-05-12T08:57:19Z

Threw a NullPointerException on usage of the static variable.

Being very new to java I overlooked the type semantics. List is apparently a reference object, so I have modified it accordingly (create a new object to reference).

Chris--A · 2015-05-12T08:59:34Z

@ArduinoBot build this please

ffissore · 2015-05-12T09:04:28Z

@ArduinoBot build this please

ArduinoBot · 2015-05-12T09:22:55Z

Build failed.

ffissore · 2015-05-12T09:27:33Z

compile:
    [mkdir] Created dir: /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/arduino-core/bin
    [javac] Compiling 121 source files to /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/arduino-core/bin
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6
    [javac] /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/arduino-core/src/cc/arduino/contributions/libraries/LibrariesIndexer.java:61: error: List is abstract; cannot be instantiated
    [javac]   private static final List<String> badLibNotified = new List<String>();
    [javac]                                                      ^
    [javac] Note: /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/arduino-core/src/processing/app/preproc/PdePreprocessor.java uses unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error
    [javac] 1 warning

Chris--A · 2015-05-12T09:38:46Z

Thank you,
On searching the error, I found this article which explained it for me nicely. http://stackoverflow.com/a/6810696/4057102

If I plan to do more IDE mods, I'll get a working compiler solution set up to avoid these errors.

ffissore · 2015-05-12T10:24:45Z

@ArduinoBot build this please

ArduinoBot · 2015-05-12T11:01:28Z

Build failed.

ffissore · 2015-05-12T11:05:47Z

compile:
    [mkdir] Created dir: /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/arduino-core/bin
    [javac] Compiling 121 source files to /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/arduino-core/bin
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6
    [javac] /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/arduino-core/src/cc/arduino/contributions/libraries/LibrariesIndexer.java:61: error: cannot find symbol
    [javac]   private static final List<String> badLibNotified = new ArrayList<String>();
    [javac]                                                          ^
    [javac]   symbol:   class ArrayList
    [javac]   location: class LibrariesIndexer
    [javac] Note: /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/arduino-core/src/processing/app/preproc/PdePreprocessor.java uses unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error
    [javac] 1 warning

I guess you really need to set up a dev env :)

Chris--A · 2015-05-12T11:18:44Z

Yeah, I'm setting one up now.
Cheers.

This patch will prevent the IDE from informing the user about a bad sketch folder name multiple times. Now the user is informed once at start up only, or once when it is detected during a rescan of the folders.

Chris--A · 2015-05-14T04:38:04Z

Had success, it works as I expected.

I got an error with the ant run process, however copying in the java folder from my 1.6.4 version allowed it to run.

windows-run:
spawn does not allow attributes related to input, output, error, result
spawn also does not allow timeout
finally, spawn is not compatible with a nested I/O

BUILD FAILED
F:\Arduino\build\build.xml:71: The following error occurred while executing this line:
F:\Arduino\build\build.xml:869: You have used an attribute or nested element which is not compatible with spawn

Chris--A · 2015-05-16T03:46:29Z

With the fix I proposed to build.xml in #3167 this compiles and runs perfectly.

ffissore · 2015-05-18T16:06:11Z

@ArduinoBot build this please

Chris--A · 2015-05-19T07:48:53Z

Arduino bot's having a long weekend.

ffissore · 2015-05-19T08:00:23Z

Yup, a maintenance activity left it disabled. Just re-enabled it

ffissore · 2015-05-19T08:05:54Z

@ArduinoBot build this please

ArduinoBot · 2015-05-19T08:47:05Z

Build successful. Please test this code using one of the following:
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3122-BUILD-272-linux32.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3122-BUILD-272-linux64.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3122-BUILD-272-windows.zip
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3122-BUILD-272-macosx.zip

ffissore · 2015-05-20T09:45:40Z

Rebased on master and pushed. See b2f8b9b. Thanks!

Federico Fissore and others added 9 commits May 8, 2015 10:18

Added .editorconfig files http://editorconfig.org/

5064af4

Windows: this launch4j conf SHOULD force using only the bundled JVM

b32d355

Windows: launch4j urls changed to generic host downloads.sourceforge.…

36cfd0a

…net instead of switch.dl.sourceforge.net

Added a note about non-standard row offsets in LiquidCrystal.cpp

fe52e7f

In my case I had to change it to make my 16x4 LCD work properly Fixes arduino#1333

Merge pull request arduino#3111 from facchinm/test-watchdog-sam-2

4688a7a

Add watchdog routines for Due

Added BaseNoGui.VERSION_NAME_LONG: it includes "Hourly Build DATE" in…

e8c4980

… case of a hourly build

Disabled port type fake menu entry. Fixes arduino#3113

050a642

Restoring left empty space on the editor

334e752

Adding keywords. Closes arduino#2213

fe94d6a

ffissore self-assigned this May 12, 2015

cmaglie added feature request A request to make an enhancement (not a bug fix) Component: IDE user interface The Arduino IDE's user interface labels May 12, 2015

IDE: prevent multiple bad name notifications.

e74c2dc

This patch will prevent the IDE from informing the user about a bad sketch folder name multiple times. Now the user is informed once at start up only, or once when it is detected during a rescan of the folders.

Chris--A force-pushed the multiple-notify-bug branch from 3fc86ca to e74c2dc Compare May 14, 2015 04:31

PaulStoffregen force-pushed the master branch from 57dcf07 to 5a68e34 Compare May 19, 2015 17:51

ffissore closed this May 20, 2015

ffissore added this to the Release 1.6.5 milestone May 20, 2015

Uh oh!

IDE: prevent multiple 'bad name' notifications. #3122

IDE: prevent multiple 'bad name' notifications. #3122

Uh oh!

Conversation

Chris--A commented May 12, 2015

Version 1.5.7

Version 1.6.3

Version 1.6.4

Uh oh!

ffissore commented May 12, 2015

Uh oh!

ArduinoBot commented May 12, 2015

Uh oh!

Chris--A commented May 12, 2015

Uh oh!

Chris--A commented May 12, 2015

Uh oh!

Chris--A commented May 12, 2015

Uh oh!

ffissore commented May 12, 2015

Uh oh!

ArduinoBot commented May 12, 2015

Uh oh!

ffissore commented May 12, 2015

Uh oh!

Chris--A commented May 12, 2015

Uh oh!

ffissore commented May 12, 2015

Uh oh!

ArduinoBot commented May 12, 2015

Uh oh!

ffissore commented May 12, 2015

Uh oh!

Chris--A commented May 12, 2015

Uh oh!

Chris--A commented May 14, 2015

Uh oh!

Chris--A commented May 16, 2015

Uh oh!

ffissore commented May 18, 2015

Uh oh!

Chris--A commented May 19, 2015

Uh oh!

ffissore commented May 19, 2015

Uh oh!

ffissore commented May 19, 2015

Uh oh!

ArduinoBot commented May 19, 2015

Uh oh!

ffissore commented May 20, 2015

Uh oh!

Uh oh!