Fix long DHCP lease times #2601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to 1.0.6
Fix for lease times > 7FFFFFFF seconds. Forever lease time is unsigned long with value FFFFFFFF. If lease time > 7FFFFFFF calling Ethernet.maintain() would force a renew every time that is wrong. Issue was decribed here: https://code.google.com/p/arduino/issues/detail?id=985
|
This does _not_ fix #2571 entirely. It needs a fix in Dhcp.cpp too. (though something between 1.0.6 and 1.6 has broken the fix by SurferTim...) |
|
Please be specific what you mean by 'entirely'. My fix is for DHCP lease time. |
cmaglie
added a commit
to cmaglie/Arduino
that referenced
this pull request
Jun 4, 2015
The signed math doesn't handle correctly cases where the lease time is set to infinity (0xFFFFFFFF). Fixes arduino#2571 Fixes arduino#2601 Fixes arduino#2642 Fixes arduino#985
|
This has been included in #3287 please follow up there. |
cmaglie
added a commit
to cmaglie/Arduino
that referenced
this pull request
Jul 14, 2015
The signed math doesn't handle correctly cases where the lease time is set to infinity (0xFFFFFFFF). Fixes arduino#2571 Fixes arduino#2601 Fixes arduino#2642 Fixes arduino#985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for lease times > 7FFFFFFF seconds.
Forever lease time is unsigned long with value FFFFFFFF.
If lease time > 7FFFFFFF, calling Ethernet.maintain() would force a renew every time. That is wrong, overloads dhcp server and generates unnecessary network traffic.
Issue was described here: https://code.google.com/p/arduino/issues/detail?id=985