Skip to content

Update README.md #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2014
Merged

Update README.md #1867

merged 1 commit into from
Feb 17, 2014

Conversation

felixphew
Copy link
Contributor

Decapitalised secondary headings and linked the Credits section

Decapitalised secondary headings and linked the *Credits* section
@matthijskooijman
Copy link
Collaborator

Patch looks good to me. Regarding the commit message, it's usually not so useful to have "Update filename" as the summary line of the commit, better just describe the change in a bit more detail there. e.g., just a single line with "In README.md, decapitalised secondary headings and linked the Credits section" is probably better. Not a big deal though, just a little remark to help you improve future contributions :-)

ffissore added a commit that referenced this pull request Feb 17, 2014
@ffissore ffissore merged commit 1d060ca into arduino:master Feb 17, 2014
@felixphew felixphew deleted the patch-2 branch February 17, 2014 19:45
@felixphew
Copy link
Contributor Author

Thanks, I’ll keep that in mind in future!

On 17 Feb 2014, at 7:01 pm, Matthijs Kooijman notifications@github.com wrote:

Patch looks good to me. Regarding the commit message, it's usually not so useful to have "Update filename" as the summary line of the commit, better just describe the change in a bit more detail there. e.g., just a single line with "In README.md, decapitalised secondary headings and linked the Credits section" is probably better. Not a big deal though, just a little remark to help you improve future contributions :-)


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants