Skip to content

Update to wiring_digital.c to use register #ifdefs instead of cpu #ifdefs [imported] #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmaglie opened this issue Nov 15, 2012 · 0 comments
Closed

Update to wiring_digital.c to use register #ifdefs instead of cpu #ifdefs [imported] #316

cmaglie opened this issue Nov 15, 2012 · 0 comments

Comments

@cmaglie
Copy link
Member

cmaglie commented Nov 15, 2012

This is Issue 316 moved from a Google Code project.
Added by 2010-08-04T14:01:06.000Z by mark.l.s...@gmail.com.
Please review that bug for more context and additional comments, but update this bug.
Closed (Fixed).

Original labels: Type-Enhancement, Priority-Medium, Component-Core, Milestone-0022

Original description

What change would like to see?

I changed the #ifdefs in turnOffPWM() to be register centric instead of cpu centric.

I also removed the inline part, it reduced the code size considerably on the mega, see comments in source code

Why?

This greatly simplifies the addition of new cpus

Would this cause any incompatibilities with previous versions? If so, how
can these be mitigated?

No compatibility problems
@cmaglie cmaglie closed this as completed Nov 15, 2012
tbowmo pushed a commit to tbowmo/Arduino that referenced this issue Jul 14, 2016
@tekka007
Merge pull request arduino#316 from mysensors/GW-INTERNAL-MSG-SEND-WI…
f895bba 
…TH-SENSOR-VALUE-255

Internal messages use sensor id 255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmaglie