Skip to content

Ethernet Library: DHCP Broadcast Spam #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Elijahg opened this issue Jan 23, 2015 · 2 comments
Closed

Ethernet Library: DHCP Broadcast Spam #2571

Elijahg opened this issue Jan 23, 2015 · 2 comments
Assignees
@cmaglie
Labels
Library: Ethernet The Ethernet Arduino library Type: Bug
Milestone
Release 1.6.5

Comments

@Elijahg
Copy link

Elijahg commented Jan 23, 2015

This has been reported in the forum but I'd like to 'officially' report it here since it's seemingly gone ignored for 3 years, and the problem still exists.

When using Ethernet.maintain(), there are a few bugs that cause the Arduino to constantly spam the network with DHCP broadcast requests - not great for battery powered devices like phones that have to awaken to process all this data (around 50k/sec I was getting).

One bug was reported on the old tracker as issue #985. That's not fixed yet, but the new one was on the forum here: http://forum.arduino.cc/index.php?topic=195422.0 . Essentially half the DHCP reply is missing, and the Library relies on the DHCP server not following the RFC and thus dishing out an existing address. DHCP servers that do follow the RFC hand out a new address, confusing things.

Both are fairly important as not to break people's networks, and fixes have been provided. It'd be a 2 minute job to fix.

I've checked the source for 1.5.x and it's not fixed there, nor in the live 1.0.6 release.

screen shot 2015-01-23 at 19 20 04
@Elijahg Elijahg changed the title Ethernet Library: DHCP Spam Ethernet Library: DHCP Broadcast Spam Jan 23, 2015
@cmaglie cmaglie added Library: Ethernet The Ethernet Arduino library Type: Bug labels Feb 4, 2015
@cmaglie cmaglie self-assigned this Feb 4, 2015
@chaveiro chaveiro mentioned this issue Feb 4, 2015
Closed
@Elijahg Elijahg mentioned this issue Feb 14, 2015
Closed
@chaveiro
Copy link
Contributor

See my comments on this before merging : bde3d71#diff-afcc783e84025d3b35532952e91130b2

cmaglie added a commit to cmaglie/Arduino that referenced this issue Jun 4, 2015
@cmaglie
Ethernet: fixed wrong handling of timeouts in DHCP
8d08c94 
The signed math doesn't handle correctly cases where the lease
time is set to infinity (0xFFFFFFFF).

Fixes arduino#2571
Fixes arduino#2601
Fixes arduino#2642
Fixes arduino#985
@cmaglie cmaglie mentioned this issue Jun 4, 2015
Merged
@cmaglie cmaglie added this to the Release 1.6.5 milestone Jun 4, 2015
@cmaglie
Copy link
Member

cmaglie commented Jun 4, 2015

A proposed fix is in #3287 please follow up there.

@cmaglie cmaglie closed this as completed Jun 4, 2015
cmaglie added a commit to cmaglie/Arduino that referenced this issue Jul 14, 2015
@cmaglie
Ethernet: fixed wrong handling of timeouts in DHCP
a33c93b 
The signed math doesn't handle correctly cases where the lease
time is set to infinity (0xFFFFFFFF).

Fixes arduino#2571
Fixes arduino#2601
Fixes arduino#2642
Fixes arduino#985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
Library: Ethernet The Ethernet Arduino library Type: Bug
Projects
None yet
Milestone
Release 1.6.5
Development

Successfully merging a pull request may close this issue.

Ethernet Library spam - fixes #2571 / #985
3 participants
@cmaglie @Elijahg @chaveiro