Skip to content

Documentation for stream.find() and derivatives is too sparse #11498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pogo555 opened this issue May 8, 2021 · 4 comments
Open

Documentation for stream.find() and derivatives is too sparse #11498

pogo555 opened this issue May 8, 2021 · 4 comments
Assignees
Labels
Component: Documentation Related to Arduino's documentation content Type: Bug

Comments

@pogo555
Copy link

pogo555 commented May 8, 2021

The documentation for these functions is almost obscure. It mentions that a target string is searched for, but does not say that this is not a String object or null terminated array of char.

The documentation for Serial.find() says that characters are read from the buffer, but does not say that they are discarded.

The documentation for file.find() is not included in the documentation for the SD library. This function alters the file position, but this is not mentioned anywhere.

Every instance could be improved with a simple best use example.

@per1234 per1234 added Component: Documentation Related to Arduino's documentation content Type: Bug labels May 8, 2021
@alranel
Copy link

alranel commented May 12, 2021

This issue should be moved to https://github.com/arduino/reference-en

@per1234
Copy link
Collaborator

per1234 commented May 12, 2021

@alranel it's tricky because the report covers two different areas of the documentation.

This part is relevant to the Language Reference:

The documentation for Serial.find() says that characters are read from the buffer, but does not say that they are discarded.

but this part is not relevant to the Language Reference:

The documentation for file.find() is not included in the documentation for the SD library. This function alters the file position, but this is not mentioned anywhere.

@kengdahl
Copy link
Member

So what can we do about this Issue? @alranel @per1234

I can assign the documentation to someone in Content if that would help.

@per1234
Copy link
Collaborator

per1234 commented Dec 21, 2021

I can assign the documentation to someone in Content if that would help.

That sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Related to Arduino's documentation content Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants