Skip to content

Fix inconsistent variable names #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix inconsistent variable names #27

wants to merge 1 commit into from

Conversation

alrvid
Copy link
Contributor

@alrvid alrvid commented Nov 3, 2023

Make all three options use the same variable name.

@alrvid
Fix inconsistent variable names
3dbb711 
Make all three options use the same variable name.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Memory usage change @ 3dbb711

Board flash % RAM for global variables %
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board extras/tests/TestExisting
flash		 % extras/tests/TestExisting
RAM for global variables		 % extras/tests/TestFileOperations
flash		 % extras/tests/TestFileOperations
RAM for global variables		 % extras/tests/TestFolderOperations
flash		 % extras/tests/TestFolderOperations
RAM for global variables		 % extras/tests/TestRepeatedFormatMount
flash		 % extras/tests/TestRepeatedFormatMount
RAM for global variables		 % extras/tests/TestUnified
flash		 % extras/tests/TestUnified
RAM for global variables		 % examples/SimpleStorageWriteRead
flash		 % examples/SimpleStorageWriteRead
RAM for global variables		 % examples/AdvancedUSBInternalOperations
flash		 % examples/AdvancedUSBInternalOperations
RAM for global variables		 % examples/BackupInternalPartitions
flash		 % examples/BackupInternalPartitions
RAM for global variables		 %
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,extras/tests/TestUnified<br>flash,%,extras/tests/TestUnified<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

cristidragomir97
cristidragomir97 requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@cristidragomir97 cristidragomir97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick to using internalStorage because in sketches where multiple types of storage are used this could get confusing

cristidragomir97
cristidragomir97 requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@cristidragomir97 cristidragomir97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick to using internalStorage because in sketches where multiple types of storage are used this could get confusing

cristidragomir97
cristidragomir97 requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@cristidragomir97 cristidragomir97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick to using internalStorage because in sketches where multiple types of storage are used this could get confusing

cristidragomir97
cristidragomir97 requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@cristidragomir97 cristidragomir97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick to using internalStorage because in sketches where multiple types of storage are used this could get confusing

cristidragomir97
cristidragomir97 requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@cristidragomir97 cristidragomir97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick to using internalStorage because in sketches where multiple types of storage are used this could get confusing

@per1234 per1234 added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Nov 3, 2023
@sebromero sebromero deleted the alrvid-patch-2 branch November 8, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristidragomir97 cristidragomir97 cristidragomir97 requested changes

Assignees
No one assigned
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrvid @cristidragomir97 @per1234