Skip to content

ESP32 support + example fix (AVR DebugUtils removal) #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

ubidefeo
Copy link
Collaborator

This PR adds ConnectionHandler support for ESP32-based boards and fixes the demo example which was still calling setDebugLevel() although that was not enabled for MegaAVR

@ubidefeo ubidefeo requested a review from aentinger January 10, 2021 21:59
@per1234
Copy link
Contributor

per1234 commented Jan 10, 2021

@ubidefeo please let me know if you want me to assist with an update of the CI workflow to also compile the examples for ESP32.

@github-actions
Copy link

Memory usage change @ 61e3a2a

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ConnectionHandlerDemo
flash
% examples/ConnectionHandlerDemo
RAM for global variables
%
arduino:mbed:envie_m4 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0
esp8266:esp8266:huzzah 0 0.0 0 0.0
Click for full report CSV
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0
esp8266:esp8266:huzzah,0,0.0,0,0.0

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @ubidefeo 🚀

@aentinger
Copy link
Contributor

@per1234 ESP32 CI support would be fantastic! I've created #48 and assigned it to you to keep track of it.

@ubidefeo
Copy link
Collaborator Author

@aentinger my previous attempt got totally messed up by SublimeText deciding to change all my whitespace and add newlines (I have some pretty messed up settings RN).
Ended up making the changes in VS Code and it all went well.

@per1234 please do! 🙏🏼

@ubidefeo
Copy link
Collaborator Author

@aentinger should I merge this on?
I guess with admin rights on the repo the flow is
PULL REQ me
REVIEW you
MERGE me

I also think that on release of this one IoTCloud should also be re-released, as I remember some changes being in there as well but not sure they've been released yet

@aentinger
Copy link
Contributor

Please go ahead and merge this one. I'd like to first have CI running for ESP32 both here (#48) and on ArduinoIoTCloud (arduino-libraries/ArduinoIoTCloud#215) before a new library is officially released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants