-
Notifications
You must be signed in to change notification settings - Fork 37
ESP32 support + example fix (AVR DebugUtils removal) #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ubidefeo please let me know if you want me to assist with an update of the CI workflow to also compile the examples for ESP32. |
Memory usage change @ 61e3a2a
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you @ubidefeo 🚀
@aentinger my previous attempt got totally messed up by SublimeText deciding to change all my whitespace and add newlines (I have some pretty messed up settings RN). @per1234 please do! 🙏🏼 |
@aentinger should I merge this on? I also think that on release of this one IoTCloud should also be re-released, as I remember some changes being in there as well but not sure they've been released yet |
Please go ahead and merge this one. I'd like to first have CI running for ESP32 both here (#48) and on ArduinoIoTCloud (arduino-libraries/ArduinoIoTCloud#215) before a new library is officially released. |
This PR adds ConnectionHandler support for ESP32-based boards and fixes the demo example which was still calling
setDebugLevel()
although that was not enabled for MegaAVR