Skip to content

Increase buffer socket size #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddaydd opened this issue May 7, 2019 · 6 comments
Open

Increase buffer socket size #68

ddaydd opened this issue May 7, 2019 · 6 comments
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@ddaydd
Copy link

ddaydd commented May 7, 2019

Hi,

can the buffer socket size be increased or is it a physical limit?

WebSocketClient.h : 89

uint8_t iTxBuffer[128];

@sandeepmistry
Copy link

Hi @ddaydd,

I think we can make the size bigger for non-AVR boards. What board are you using and what size do you need?

@sandeepmistry sandeepmistry added the status: waiting for information More information must be provided before work can proceed label May 13, 2019
@ddaydd
Copy link
Author

ddaydd commented May 13, 2019

my hardware is arduino mega 2560 with ethernet shield W5100,
I think 200 characters would be fine, it's possible?

@ddaydd
Copy link
Author

ddaydd commented Jun 7, 2019

@sandeepmistry no news?

@clysss
Copy link

clysss commented Dec 5, 2020

Is there a good reason not to create a setitXBuffersize function or add a constrctor to websocket ? Or at least a way to modify via #define...
What's the best option to your opinion..?

This is a large limitation of clean reuse httparduinoclient on other websocket project like mqtt/pubsubclient over wss... (Cf Areve repo)

@asoap
Copy link

asoap commented Feb 11, 2021

Thank you for this comment thread. I'm a noob that had an issue sending websockets using an Arduino Nano Uno Rev2. I got it work but as soon as I sent a semi bigger socket command it would screw up the Arduino. I just increased that iTxBuffer to 256 and I'm back in business!!!!

@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement and removed status: waiting for information More information must be provided before work can proceed labels Jan 25, 2022
@per1234 per1234 changed the title buffer socket size Increase buffer socket size Jan 25, 2022
@per1234
Copy link

per1234 commented Jan 25, 2022

at least a way to modify via #define

There is now a proposal for that here: #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

5 participants