Skip to content

Commit 1fe4eb8

Browse files
committed
build: fixes the docs lint setup to work
Fixes the docs lint setup to work. It failed due to some missing dependencies in pnpm. We should consider dropping this and just use Prettier IMO. Although I can see some useful linting of Angular specific code.
1 parent f4bf900 commit 1fe4eb8

File tree

5 files changed

+131
-252
lines changed

5 files changed

+131
-252
lines changed

docs/.eslintrc.json

+5-7
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
"createDefaultProgram": true
1111
},
1212
"extends": [
13-
"plugin:@angular-eslint/ng-cli-compat",
14-
"plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
13+
"plugin:@angular-eslint/recommended",
1514
"plugin:@angular-eslint/template/process-inline-templates",
1615
"plugin:@stylistic/disable-legacy"
1716
],
@@ -80,11 +79,10 @@
8079
"files": ["*.html"],
8180
"extends": ["plugin:@angular-eslint/template/recommended"],
8281
"rules": {
83-
"@angular-eslint/template/accessibility-alt-text": "error",
84-
"@angular-eslint/template/accessibility-elements-content": "error",
85-
"@angular-eslint/template/accessibility-label-for": "error",
86-
"@angular-eslint/template/accessibility-table-scope": "error",
87-
"@angular-eslint/template/accessibility-valid-aria": "error",
82+
"@angular-eslint/template/alt-text": "error",
83+
"@angular-eslint/template/elements-content": "error",
84+
"@angular-eslint/template/table-scope": "error",
85+
"@angular-eslint/template/valid-aria": "error",
8886
"@angular-eslint/template/click-events-have-key-events": "error",
8987
"@angular-eslint/template/mouse-events-have-key-events": "error",
9088
"@angular-eslint/template/no-autofocus": "error",

docs/package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,19 @@
5959
"@angular-devkit/architect": "catalog:",
6060
"@angular-devkit/architect-cli": "catalog:",
6161
"@angular-devkit/build-angular": "catalog:",
62-
"@angular-eslint/builder": "^14.0.0",
63-
"@angular-eslint/eslint-plugin": "^14.0.0",
64-
"@angular-eslint/eslint-plugin-template": "^14.0.0",
65-
"@angular-eslint/template-parser": "^14.0.0",
66-
"@angular/cli": "^20.0.0-next.3",
62+
"@angular-eslint/builder": "19.3.0",
63+
"@angular-eslint/eslint-plugin": "19.3.0",
64+
"@angular-eslint/eslint-plugin-template": "19.3.0",
65+
"@angular-eslint/template-parser": "19.3.0",
66+
"@angular/cli": "catalog:",
6767
"@angular/compiler-cli": "catalog:",
6868
"@bazel/bazelisk": "^1.12.1",
6969
"@stylistic/eslint-plugin": "^2.6.2",
7070
"@types/jasmine": "5.1.7",
7171
"@types/node": "^22.14.1",
7272
"@types/shelljs": "0.8.15",
73-
"@typescript-eslint/eslint-plugin": "^8.26.0",
74-
"@typescript-eslint/parser": "^8.26.0",
73+
"@typescript-eslint/eslint-plugin": "8.29.1",
74+
"@typescript-eslint/parser": "8.29.1",
7575
"eslint": "^8.56.0",
7676
"eslint-plugin-ban": "^1.5.2",
7777
"eslint-plugin-import": "^2.22.1",

docs/src/app/shared/navigation-focus/navigation-focus.spec.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ describe('Navigation focus service', () => {
1717

1818
beforeEach(() => {
1919
TestBed.configureTestingModule({
20-
imports: [NavigationFocus],
21-
declarations: [NavigationFocusTest, RouteTest],
2220
providers: [
2321
provideRouter([
2422
{path: '', component: RouteTest},
@@ -123,13 +121,12 @@ describe('Navigation focus service', () => {
123121
<button id="target2">Target 2</button>
124122
<button class="no-id" focusOnNavigation>Target 3</button>
125123
`,
126-
standalone: false,
124+
imports: [NavigationFocus],
127125
})
128126
class NavigationFocusTest {}
129127

130128
@Component({
131129
selector: 'route-test',
132130
template: '',
133-
standalone: false,
134131
})
135132
class RouteTest {}

package.json

+6
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,12 @@
168168
"clonedeep": "*"
169169
}
170170
},
171+
"@angular-eslint/eslint-plugin-template@19.3.0": {
172+
"peerDependencies": {
173+
"@typescript-eslint/parser": "*",
174+
"@angular-eslint/template-parser": "*"
175+
}
176+
},
171177
"@angular/animations": {
172178
"dependencies": {
173179
"@nginfra/angular-linking": "1.0.9"

0 commit comments

Comments
 (0)