Skip to content

Manually instrument 10 functions with high CC #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adambenali opened this issue Feb 14, 2020 · 9 comments
Closed

Manually instrument 10 functions with high CC #3

adambenali opened this issue Feb 14, 2020 · 9 comments
Assignees
@jrutqvist

Comments

@adambenali
Copy link
Owner

adambenali commented Feb 14, 2020 •
edited by pandaseal
Loading

The function should have a CC > 10 and have bad test coverage.
Write 2 tests each, preferably for 2 different functions (among these 10!).
@jrutqvist
Copy link
Collaborator

I'm gonna call dibs on the function index 0 (instrumentation point indexes 0-99) for Matrix.add to test instrumentation on!

jrutqvist added a commit that referenced this issue Feb 14, 2020
@jrutqvist
Implement instrumentation for Matrix.add #3
f6c42cc
@ChangGabriel
Copy link
Collaborator

ChangGabriel commented Feb 16, 2020 •
edited
Loading

I will do one test for Matrix.compare() line:27 - 57 and Dijkstra::getShortestPath line:57 - 134.

@adambenali
Copy link
Owner Author

adambenali commented Feb 16, 2020 •
edited
Loading

I'm taking FenwickTree::combined (index 100->199) and FenwickTree::separate (index 200->299).

@jrutqvist
Copy link
Collaborator

Ill do BinarySearchTree:getDFS with indexes 300-399!

jrutqvist added a commit that referenced this issue Feb 16, 2020
@jrutqvist
Implement instrumentation of BinarySearchTree.getDFS #3
10dfdeb
@hanzhsun
Copy link
Collaborator

I will take BinaryHeapArray::validateNode (index 400->499) and BinaryHeapTree::validateNode (index 500->599).

@jrutqvist jrutqvist self-assigned this Feb 17, 2020
@jrutqvist jrutqvist mentioned this issue Feb 17, 2020
Merged
jrutqvist added a commit that referenced this issue Feb 17, 2020
@jrutqvist
Merge pull request #5 from adambenali/cov-instr/2
48e127c 
Implement instrumentation for Matrix.add #3
@jrutqvist jrutqvist mentioned this issue Feb 17, 2020
Merged
jrutqvist added a commit that referenced this issue Feb 17, 2020
@jrutqvist
Merge pull request #6 from adambenali/bst-dfs
b39c24b 
Implement instrumentation of BinarySearchTree.getDFS #3
@jrutqvist
Copy link
Collaborator

jrutqvist commented Feb 17, 2020 •
edited
Loading

Ok @hanzhsun @ChangGabriel I'll do instrumentation for your functions now! As well as for two functions for @pandaseal

@jrutqvist
Copy link
Collaborator

Ill call indexes 6 (600-699) and 7 (700-799) for @ChangGabriel's functions and 8 and 9 for @pandaseal's functions

@jrutqvist
Copy link
Collaborator

@pandaseal gets KdTree.searchNode and SuffixTree:TreePrinter:getString!

adambenali added a commit that referenced this issue Feb 17, 2020
@adambenali
Add instrumentation for FenwickTree::combined & FenwickTree:separate #3
246ddb9
jrutqvist added a commit that referenced this issue Feb 17, 2020
@jrutqvist
Add instrumentation for Matrix compare #3
54c5e69
jrutqvist added a commit that referenced this issue Feb 17, 2020
@jrutqvist
Add instrumentation for Dijkstra getShortestPath #3
dcd00fd
jrutqvist added a commit that referenced this issue Feb 17, 2020
@jrutqvist
Change coverage print to actually display percentage #3
a7dd948
jrutqvist added a commit that referenced this issue Feb 17, 2020
@jrutqvist
Instrumentation of BinaryHeap Array and Tree validateNode #3
a1109b9
jrutqvist added a commit that referenced this issue Feb 17, 2020
@jrutqvist
Remove unnecesary import #3
fed6e5d
@jrutqvist jrutqvist mentioned this issue Feb 17, 2020
Merged
adambenali added a commit that referenced this issue Feb 17, 2020
@adambenali
Add instrumentation for KdTree.searchNode #3
fa75556
adambenali added a commit that referenced this issue Feb 17, 2020
@adambenali
Add instrumentation for SuffixTree.TreePrinter::getString #3
3db28aa
ChangGabriel added a commit that referenced this issue Feb 17, 2020
@ChangGabriel
Merge pull request #8 from adambenali/fenwick-tree-cov
25ae101 
Add instrumentation for FenwickTree::combined & FenwickTree:separate #3
@pandaseal
Copy link
Collaborator

pandaseal commented Feb 18, 2020 •
edited
Loading

I will write tests for Matrix.equals() and Primes.isPrime().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrutqvist jrutqvist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ChangGabriel @pandaseal @adambenali @jrutqvist @hanzhsun