Update abs_Max.py #997
Merged
Update abs_Max.py #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix docstring for doctest to work properly (add space after >>>)
|
Let's add Python type hints to make it even more impressive: from typing import List
def abs_max(x: List[int]) -> int: |
|
Also, see why the Travis CI tests are failing. |
|
Great Advice. Updated. |
cclauss
approved these changes
Jul 11, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Update abs_Max.py fix docstring for doctest to work properly (add space after >>>) * Update abs_Max.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix docstring for doctest to work properly (add space after
>>>). Added another possible method of finding abs_max(), Changed function name according to repo guidelines. I understand these changes are trivial ,please close PR if so.