Skip to content

Create Quadratic Equations(Complexes Numbers) #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Create Quadratic Equations(Complexes Numbers) #941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68bac4e
Create Quadratic Equations(Complexes Numbers)
AugustofCravo Jul 2, 2019
e5a28b9
Update Quadratic Equations(Complexes Numbers)
harshildarji Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions maths/Quadratic Equations(Complexes Numbers)
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
from __future__ import print_function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshildarji This repo no longer supports legacy Python so we should avoid adding those __future__ imports which are no longer relevant in Python 3. Adding them give the impression that we tested these scripts on legacy Python which we do not do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss Looking at the failure logs, I thought this could solve the issue. My bad! I'll remove it and see if it still gives the error!
Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem may be that the filename contains spaces and uppercase characters so validate_filenames will fail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss Please review #1102. The main problem indeed was the filename as it was without proper .py extension. I have changed the filename as well as removed the from __future__ import print_function line from the code.

import math

def QuadraticEquation(a,b,c):
"""
Prints the solutions for a quadratic equation, given the numerical coefficients a, b and c,
for a*x*x + b*x + c.
Ex.: a = 1, b = 3, c = -4
Solution1 = 1 and Solution2 = -4
"""
Copy link
Member

@cclauss cclauss Jul 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Please consider adding these two doctests at the end of this function's docstring:

    >>> QuadraticEquation(a=1, b=3, c=-4)
    The equation solutions are:  1.0 and -4.0
    >>> QuadraticEquation(5, 6, 1)
    The equation solutions are:  -0.2  and  -1.0

Our automated testing can then run the first line and raise an error if the result does not match the second line.

Delta = b*b - 4*a*c
if a != 0:
if Delta >= 0:
Solution1 = (-b + math.sqrt(Delta))/(2*a)
Solution2 = (-b - math.sqrt(Delta))/(2*a)
print ("The equation solutions are: ", Solution1," and ", Solution2)
else:
"""
Treats cases of Complexes Solutions(i = imaginary unit)
Ex.: a = 5, b = 2, c = 1
Solution1 = (- 2 + 4.0 *i)/2 and Solution2 = (- 2 + 4.0 *i)/ 10
"""
if b > 0:
print("The equation solutions are: (-",b,"+",math.sqrt(-Delta),"*i)/2 and (-",b,"+",math.sqrt(-Delta),"*i)/", 2*a)
if b < 0:
print("The equation solutions are: (",b,"+",math.sqrt(-Delta),"*i)/2 and (",b,"+",math.sqrt(-Delta),"*i/",2*a)
if b == 0:
print("The equation solutions are: (",math.sqrt(-Delta),"*i)/2 and ",math.sqrt(-Delta),"*i)/", 2*a)
else:
print("Error. Please, coeficient 'a' must not be zero for quadratic equations.")
def main():
a = 5
b = 6
c = 1

QuadraticEquation(a,b,c) # The equation solutions are: -0.2 and -1.0


if __name__ == '__main__':
main()