Bi directional dijkstra #7982
Merged
Bi directional dijkstra #7982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
awaiting reviews
![algorithms-keeper[bot]](https://flashblogg.com:443/je/cache.php/https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
removed
require tests
algorithms-keeper
bot
removed
the
tests are failing
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
CaedenPH
reviewed
Nov 13, 2022
graphs/bi_directional_dijkstra.py
Outdated
Comment on lines
120
to
139
| graph_fwd = { | ||
| "B": [["C", 1]], | ||
| "C": [["D", 1]], | ||
| "D": [["F", 1]], | ||
| "E": [["B", 1], ["G", 2]], | ||
| "F": [], | ||
| "G": [["F", 1]], | ||
| } | ||
| graph_bwd = { | ||
| "B": [["E", 1]], | ||
| "C": [["B", 1]], | ||
| "D": [["C", 1]], | ||
| "F": [["D", 1], ["G", 1]], | ||
| "G": [["E", 2]], | ||
| } | ||
| print( | ||
| bidirectional_dij("E", "F", graph_fwd, graph_bwd) | ||
| ) # # E -- 2 --> G -- 1 --> F == 3 | ||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
This should be moved within the if name == main
There was a problem hiding this comment.
Cannot put graph_fwd and graph_bwd inside any other scope because it was giving error in the GitHub workflow while running test that graph_fwd is not defined
There was a problem hiding this comment.
It has to stay the global scope, I did moved it inside if __name__ == "__main__ and it is working locally but somehow not passing this GitHub workflow
|
Please fix the checks as well |
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
for more information, see https://pre-commit.ci
|
All check blockers are resolved @CaedenPH |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
darkieee
approved these changes
Nov 14, 2022
CaedenPH
reviewed
Nov 14, 2022
Comment on lines
+109
to
+124
| graph_fwd = { | ||
| "B": [["C", 1]], | ||
| "C": [["D", 1]], | ||
| "D": [["F", 1]], | ||
| "E": [["B", 1], ["G", 2]], | ||
| "F": [], | ||
| "G": [["F", 1]], | ||
| } | ||
| graph_bwd = { | ||
| "B": [["E", 1]], | ||
| "C": [["B", 1]], | ||
| "D": [["C", 1]], | ||
| "F": [["D", 1], ["G", 1]], | ||
| "E": [[None, np.inf]], | ||
| "G": [["E", 2]], | ||
| } |
There was a problem hiding this comment.
Move this within the doctest - its why it failed earlier
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
ChrisO345
approved these changes
Nov 20, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
Cjkjvfnby
pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
* Added Bi-Directional Dijkstra * Added Bi-Directional Dijkstra * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added doctest and type hints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Rename Bi_directional_Dijkstra.py to bi_directional_dijkstra.py * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bi_directional_dijkstra.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.