Modified 'pascal_triangle.py' program #7901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed function to generate pascal's triangle to 'pascal_triangle.py' program. Added some aadditional doctests to the existing function. Added some type check functionality to the existing function.
algorithms-keeper
bot
added
enhancement
for more information, see https://pre-commit.ci
|
Cool! Please add a timeit (or similar) benchmark to prove that the proposed code is faster than the original code. There are lots of examples in this repo. https://github.com/TheAlgorithms/Python/search?q=timeit but https://github.com/TheAlgorithms/Python/blob/master/bit_manipulation/count_number_of_one_bits.py#L63 is probably one of the best. |
cclauss
reviewed
Oct 31, 2022
other/pascal_triangle.py
Outdated
Comment on lines
158
to
160
| distinct_elements = ( | ||
| row_length // 2 if row_length % 2 == 0 else row_length // 2 + 1 | ||
| ) |
There was a problem hiding this comment.
Leverage the Python builtin functions:
Suggested change
| distinct_elements = ( | |
| row_length // 2 if row_length % 2 == 0 else row_length // 2 + 1 | |
| ) | |
| distinct_elements = sum(divmod(row_length, 2)) |
cclauss
reviewed
Oct 31, 2022
other/pascal_triangle.py
Outdated
Comment on lines
162
to
164
| row_first_half = [ | ||
| temp_row[x - 1] + temp_row[x] for x in range(1, distinct_elements + 1) | ||
| ] |
There was a problem hiding this comment.
Use i for integers, indexes, etc. Use item for objects in a list. Use x only when space is tight.
Suggested change
| row_first_half = [ | |
| temp_row[x - 1] + temp_row[x] for x in range(1, distinct_elements + 1) | |
| ] | |
| row_first_half = [item + temp_row[i + 1] for i, item in enumerate(temp_row)] |
|
The benchmarks show that for some values of |
cclauss
approved these changes
Oct 31, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change: Added a new optimized function 'generate_pascal_triangle_optimized' to generate Pascal's Triangle to the existing 'pascal_triangle.py' file which reduces the computations done for each row by half. It reduces the redundant computations in generating each row. Also, added type check functionalities, which raise 'ValueError' and 'TypeError', to the existing 'generate_pascal_triangle' function. Also, added 3 additional doctests for the existing 'generate_pascal_triangle' function'.
Checklist:
Fixes: #{$ISSUE_NO}.