Skip to content

Create potential_energy.py #7666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 29, 2022
Merged

Create potential_energy.py #7666

merged 10 commits into from
Oct 29, 2022

Conversation

SparshRastogi
Copy link
Contributor

Finding the gravitational potential energy of an object with reference to the earth, by taking its mass and height above the ground as input

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@SparshRastogi
Create potential_energy.py
faed05b 
Finding the gravitational potential energy of an object with reference to the earth, by taking its mass and height above the ground as input
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 26, 2022
ChrisO345
ChrisO345 reviewed Oct 26, 2022
View reviewed changes
ChrisO345
ChrisO345 reviewed Oct 26, 2022
View reviewed changes
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 27, 2022
Closed
14 tasks
SparshRastogi and others added 2 commits October 27, 2022 16:41
@SparshRastogi @ChrisO345
Update physics/potential_energy.py
d26d98b 
Co-authored-by: Chris O <46587501+ChrisO345@users.noreply.github.com>
@SparshRastogi @ChrisO345
Update physics/potential_energy.py
cb740a7 
Co-authored-by: Chris O <46587501+ChrisO345@users.noreply.github.com>
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 27, 2022
CaedenPH
CaedenPH reviewed Oct 27, 2022
View reviewed changes
SparshRastogi and others added 6 commits October 27, 2022 21:13
@SparshRastogi @CaedenPH
Update physics/potential_energy.py
24ce9b8 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@SparshRastogi @CaedenPH
Update physics/potential_energy.py
908245d 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@SparshRastogi @CaedenPH
Update physics/potential_energy.py
0553b78 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@SparshRastogi @CaedenPH
Update physics/potential_energy.py
1d44b43 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@SparshRastogi @CaedenPH
Update physics/potential_energy.py
aaf171f 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b3e4a0a 
for more information, see https://pre-commit.ci
CaedenPH
CaedenPH approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisO345 I believe he made the changes you asked for, you could review again please?

ChrisO345
ChrisO345 previously requested changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@ChrisO345 ChrisO345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add scipy to the requirements.txt as part of this PR

@SparshRastogi
Copy link
Contributor Author

Could you please add scipy to the requirements.txt as part of this PR

@ChrisO345 for that I would need to create a directory for this file but all the other files are just individual Python files in this directory,and in the pull request also I acknowledged that I am creating a single file inside an existing directory,so I don't think it would be great

@ChrisO345 ChrisO345 dismissed their stale review October 29, 2022 11:12

Irrelevant

@ChrisO345 ChrisO345 merged commit 301a520 into TheAlgorithms:master Oct 29, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 29, 2022
@ChrisO345 ChrisO345 added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@ChrisO345 ChrisO345 ChrisO345 approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SparshRastogi @CaedenPH @ChrisO345