Skip to content

Remove type cast in combinations algorithm #7607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 25, 2022
Merged

Remove type cast in combinations algorithm #7607

merged 20 commits into from
Oct 25, 2022

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

Replaced type cast to int in maths/combinations.py with integer division because the mathematical formula for nCr(n, k) always evaluates to an integer anyways.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 24, 2022
@cclauss cclauss merged commit d25187e into TheAlgorithms:master Oct 25, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 25, 2022
@cclauss
Copy link
Member

cclauss commented Oct 25, 2022

@ChrisO345 If you see PRs that have passing tests and adhere to our guidelines, and that you approve of, please go ahead an squash and merge. We should try to get the 200 open PRs down to something more reasonable.

@tianyizheng02 tianyizheng02 deleted the combinations branch October 25, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants