Skip to content

My favorite palindrome #7455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 23, 2022
Merged

My favorite palindrome #7455

merged 7 commits into from
Oct 23, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 20, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 20, 2022
CaedenPH
CaedenPH reviewed Oct 20, 2022
View reviewed changes
@cclauss @CaedenPH
Update strings/is_palindrome.py
171501d 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@cclauss cclauss requested a review from CaedenPH October 20, 2022 17:50
CaedenPH
CaedenPH reviewed Oct 20, 2022
View reviewed changes
strings/is_palindrome.py Outdated
:param s:
:return: Boolean
>>> is_palindrome("a man a plan a canal panama".replace(" ", ""))
Determine if the string s is palindrome.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Determine if the string s is palindrome.
Determine if the string s is palindromic.

strings/is_palindrome.py Outdated
# Palindrome, we first remove them from our string.
s = "".join([character for character in s.lower() if character.isalnum()])
# Since punctuation, capitalization, and spaces are often ignored while checking
# palindromes, we first remove them from our string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# palindromes, we first remove them from our string.
# palindromes, we first remove them from our string.

@cclauss cclauss requested a review from CaedenPH October 20, 2022 18:10
CaedenPH
CaedenPH approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cclauss
Copy link
Member Author

cclauss commented Oct 23, 2022

@dhruvmanila @poyea

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2022
@cclauss cclauss merged commit b8b6346 into master Oct 23, 2022
@cclauss cclauss deleted the My-favorite-palindrome branch October 23, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @CaedenPH @dhruvmanila