Skip to content

Update gaussian_naive_bayes.py #7406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2022
Merged

Update gaussian_naive_bayes.py #7406

merged 2 commits into from
Oct 19, 2022

Conversation

mvsg2
Copy link
Contributor

@mvsg2 mvsg2 commented Oct 18, 2022 •
edited by cclauss
Loading

Fixes #7407

Just adding in a final metric of accuracy to declare...

Describe your change:

I have imported another module from sklearn.metrics library i.e. accuracy_score to display the final accuracy of the trained model out on the console. Also, just to make it a little propped up, I also imported the time library and stopped the code-execution at two points in the middle (this won't affect the final accuracy of the model in any way).

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

mvsg2 and others added 2 commits October 18, 2022 22:44
@mvsg2
Update gaussian_naive_bayes.py
0379c64 
Just adding in a final metric of accuracy to declare...
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f3ec191 
for more information, see https://pre-commit.ci
@ZeroDayOwl ZeroDayOwl mentioned this pull request Oct 19, 2022
Closed
14 tasks
cclauss
cclauss reviewed Oct 19, 2022
View reviewed changes
machine_learning/gaussian_naive_bayes.py
@@ -25,20 +27,26 @@ def main():

# Gaussian Naive Bayes
nb_model = GaussianNB()
nb_model.fit(x_train, y_train)
time.sleep(2.9)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we waiting for 3 seconds?!? Comments needed to be added to explain such things.

@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 19, 2022
@cclauss cclauss merged commit 80ff25e into TheAlgorithms:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvsg2 @cclauss