Skip to content

pre-commit.ci working so drop less powerful GHA #6565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

pre-commit.ci working so drop less powerful GHA #6565

merged 1 commit into from
Oct 3, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 2, 2022 •
edited
Loading

pre-commit.ci is working so let's remove our redundant and less powerful GitHub Action that runs pre-commit.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
pre-commit.ci working so drop less powerful GHA
86c7b4c 
[`pre-commit.ci` is working](https://results.pre-commit.ci/repo/github/63476337) so let's remove our redundant and less powerful GitHub Action.
@cclauss cclauss requested a review from dhruvmanila as a code owner October 2, 2022 20:08
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 2, 2022
dhruvmanila
dhruvmanila approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 🎉

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 3, 2022
@dhruvmanila dhruvmanila merged commit e9862ad into master Oct 3, 2022
@cclauss cclauss deleted the Remove_redundant_pre-commit_GitHub_Action branch October 3, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@poyea poyea Awaiting requested review from poyea

@AnshulMalik AnshulMalik Awaiting requested review from AnshulMalik

@AnupKumarPanwar AnupKumarPanwar Awaiting requested review from AnupKumarPanwar

@deadshotsb deadshotsb Awaiting requested review from deadshotsb

@dynamitechetan dynamitechetan Awaiting requested review from dynamitechetan

@Kush1101 Kush1101 Awaiting requested review from Kush1101

@l3str4nge l3str4nge Awaiting requested review from l3str4nge

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @dhruvmanila