Invalid issue raised #6448

ruchirmehta07 · 2022-10-01T09:01:11Z

Describe your change:

Hi,
I observed that the below issue raised is invalid and doesn't comply with the guidelines and should be marked as invalid/resolved.
#6377

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

* Created new persistence algorithm * Update persistence.py * Added another persistence function

* makes LRUCache constructor concrete * fixes bug in dq_removal in other/least_recently_used + deque.remove() operates by value not index * [mypy] Annotates other/least_recently_used over generic type + clean-up: rename key_reference to match type. * [mypy] updates example to demonstrate LRUCache with complex type * Adds doctest to other/least_recently_used * mypy.ini: Remove exclude = (other/least_recently_used.py) * Various mypy configs * Delete mypy.ini * Add mypy to .pre-commit-config.yaml * mypy --ignore-missing-imports --install-types --non-interactive . * mypy v0.910 * Pillow=8.3.7 * Pillow==8.3.7 * Pillow==8.3.2 * Update .pre-commit-config.yaml * Update requirements.txt * Update pre-commit.yml * --install-types # See mirrors-mypy README.md Co-authored-by: Christian Clauss <cclauss@me.com>

* adding pooling algorithms * pooling.py: Adding pooling algorithms to computer vision pull_number= * pooling.py: Adding pooling algorithms to computer vision * pooling_functions.py: Adding pooling algorithms to computer vision * pooling.py: Adding Pooling Algorithms * pooling_functions.py Add and Update * Update pooling_functions.py * Update computer_vision/pooling_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update computer_vision/pooling_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update computer_vision/pooling_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update computer_vision/pooling_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update pooling_functions.py * Formatting pooling.py Co-authored-by: Christian Clauss <cclauss@me.com>

* Replace typing.optional with new annotations syntax * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

* Updated the comments in the code * Update .gitignore * Update .gitignore * Update .gitignore Co-authored-by: Christian Clauss <cclauss@me.com>

* Added memoization function in fibonacci * Minor changes

* Update merge_insertion_sort.py Fixes #5774 merge_insertion_sort Co-Authored-By: AilisOsswald <44617437+AilisOsswald@users.noreply.github.com> * Update merge_insertion_sort.py Fixes #5774 merge_insertion_sort Co-Authored-By: AilisOsswald <44617437+AilisOsswald@users.noreply.github.com> * Update merge_insertion_sort.py Fixes #5774 added permutation range from 0 to 4 Co-Authored-By: AilisOsswald <44617437+AilisOsswald@users.noreply.github.com> * Use `all()` Co-authored-by: AilisOsswald <44617437+AilisOsswald@users.noreply.github.com> Co-authored-by: John Law <johnlaw.po@gmail.com>

* Syntax improvements (I hope) to boolean algebra * Reverted certain index variables to i * remove extra line on decimal_to_binary * Update quine_mc_cluskey.py Co-authored-by: John Law <johnlaw.po@gmail.com>

* ci: add mkdir step for mypy * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

* Update currency_converter.py * refactor: add types and remove reserved keyword "from" usage * feat: update text * Update web_programming/currency_converter.py Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com> * Update web_programming/currency_converter.py Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com> * fix: update currency_converter.py * updating DIRECTORY.md * Update currency_converter.py Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>

* The black formatter is no longer beta * pre-commit autoupdate * pre-commit autoupdate * Remove project_euler/problem_145 which is killing our CI tests * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

… drug name and zipcode (#5967) * add wellrx scraping * write test fix docs * fix resolve issues * black format. fix returns * type check fix for union * black formatted * Change requests after code review * add precommit changes * flake errors

…5975) * fetch anime * formatted code * fix format errors * fix bot reviews * pr review fixes * remove unussed exception * change var name * fix comments

) * works python3 -m unittest discover --start-directory src --pattern "power*.py" --t . -v * cleanup * revert switch to unittest * fix flake8

* Upgrade to Python 3.10 * Upgrade to Python 3.10 * mypy || true * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

* pyupgrade --py310-plus and run mypy in precommit, not build * pyupgrade --py310-plus web_programming/fetch_well_rx_price.py * pyupgrade --py310-plus web_programming/fetch_well_rx_price.py * Fix arithmetic_analysis/in_static_equilibrium.py * Fix arithmetic_analysis/in_static_equilibrium.py

* Add points are collinear in 3d algorithm to /maths * Apply suggestions from code review in points_are_collinear_3d.py Thanks to cclauss. Co-authored-by: Christian Clauss <cclauss@me.com> * Rename some variables to be more self-documenting. * Update points_are_collinear_3d.py Co-authored-by: Christian Clauss <cclauss@me.com>

* Added average absolute deviation * Formats program with black * reruns updated pre commit * Update average_absolute_deviation.py Co-authored-by: Christian Clauss <cclauss@me.com>

* 📝 Updated year Fixes: #5916 * Update LICENSE.md Co-authored-by: John Law <johnlaw.po@gmail.com>

black==22.1.0 is breaking the hook. Updating it to 22.3.0 fixes all the issue Refer: python-poetry/poetry#5375

* feat: added ngram algorithm * fix(test): use `math.isclose` to match floating point numbers approximately Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* Add files via upload * Changed print to f-string Also printed out results in a math notation * Add files via upload * Fixes: #4710 provided return type * File exists in another pull request * imported radians from math * Updated file according to pre-commit test * Updated file * Updated gamma * Deleted duplicate file * removed pi * reversed tests * Fixed angle condition * Modified prints to f-string * Update horizontal_projectile_motion.py * Update horizontal_projectile_motion.py * Fixes #4710 added exceptions and tests * Added float tests * Fixed type annotations * Fixed last annotation * Fixed annotations * fixed format * Revert "fixed format" This reverts commit 5b0249a. Undo changes @wq * Revert "Fixed annotations" This reverts commit c37bb95. * Revert "Fixed last annotation" This reverts commit e3678fd. * Revert "Fixed type annotations" This reverts commit 3f2b238. * Revert to 4e2fcaf * Fixing errors found during pre-commit

* Fixes (#5434) * Update ciphers.rabin_miller.py maths.miller_rabin.py * Fixing ERROR maths/miller_rabin.py - ModuleNotFoundError and changing project_euler's isPrime to is_prime function names * Update sol1.py * fix: try to change to list * fix pre-commit * fix capital letters * Update miller_rabin.py * Update rabin_miller.py Co-authored-by: John Law <johnlaw.po@gmail.com>

* Fix quicksort doc * add binary tree traversals doc * Add link to the reference * Fix job * Change url * Update binary_tree_traversals.md * Update normal_distribution_quick_sort.md * Update normal_distribution_quick_sort.md Co-authored-by: John Law <johnlaw.po@gmail.com>

* First commit for add_prefix_conversion * Class names in CamelCase, str.format() to f-string * Fixed following pre-commit guidelines * solved issues with mypy and enum.Enum * Rename add_prefix_conversion.py to prefix_conversions_string.py Co-authored-by: John Law <johnlaw.po@gmail.com>

* Fix some typos. * Update volume.py Co-authored-by: John Law <johnlaw.po@gmail.com>

* fix black at prefix string * Type -> type * Type unused

* Solution to Problem 145 of Project Euler * Provided more descriptive filename * Update sol1.py Co-authored-by: John Law <johnlaw.po@gmail.com>

* Hacktoberfest: added sol for P104 Project Euler * bot requests resolved * pre-commit * Update sol.py * Update sol.py * remove trailing zeroes * Update sol.py * Update sol.py * Update sol.py Co-authored-by: John Law <johnlaw.po@gmail.com>

* Added implementation of the Horn-Schunck algorithm * Cleaner variable names * added doctests * Fix doctest * Update horn_schunck.py * Update horn_schunck.py * Update horn_schunck.py * Update horn_schunck.py Co-authored-by: John Law <johnlaw.po@gmail.com>

Improve solution (locally 1500+ times - from 3+ seconds to ~2 milliseconds) Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

* Add `MaxFenwickTree` * Reformat code style * Fix type hints * Fix type hints again * Complete docstring * Complete docstring * Fix typo in file name * Change MaxFenwickTree into 0-based indexing * Fix Bugs * Minor fix

* Enhance fenwick_tree.py * Change update to add in fenwick_tree.py * Some changes * Fix bug * Add O(N) initializer to FenwickTree * Add get method to Fenwick Tree * Change tree in Fenwick Tree * Add rank query to FenwickTree * Add get_array method to FenwickTree * Add some tests * Update data_structures/binary_tree/fenwick_tree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/binary_tree/fenwick_tree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/binary_tree/fenwick_tree.py Co-authored-by: Christian Clauss <cclauss@me.com> * change `List` to `list` Co-authored-by: Christian Clauss <cclauss@me.com>

* add algorithm local binary pattern * fix failed test for local binary pattern * updating DIRECTORY.md * fix detected precommit-error * fix precommit error * final check * Add descriptive name for parameters x and y * Update digital_image_processing/filters/local_binary_pattern.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update digital_image_processing/filters/local_binary_pattern.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update digital_image_processing/filters/local_binary_pattern.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update local_binary_pattern.py * undo changes made on get_neighbors_pixel() * files formatted by black * Update digital_image_processing/filters/local_binary_pattern.py ok thanks Co-authored-by: Christian Clauss <cclauss@me.com> * add test for get_neighbors_pixel() function * reviewed * fix get_neighbors_pixel * Update test_digital_image_processing.py * updating DIRECTORY.md * Create code_quality.yml * Create code_quality.yml * Delete code_quality.yml * Update code_quality.yml * Delete code_quality.yml Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>

* adding the dna algorithm * following bot recommendations following bot recommendations for the indentation * following bot recommendations following bot recommendations regarding indentation [ again ] * following bot recommendations following bot recommendations regarding indentation [ again. ] * following bot recommendations following bot recommendations.

* fixes #5434 * fixes broken solution * removes assert * removes assert * Apply suggestions from code review Co-authored-by: John Law <johnlaw.po@gmail.com> * Update project_euler/problem_003/sol1.py Co-authored-by: John Law <johnlaw.po@gmail.com>

* Add Optimized Shell Sort * Added return type * reformatted * added shrink_shell.py * ran directory generator * Rename shrink_shell.py to shrink_shell_sort.py Co-authored-by: John Law <johnlaw.po@gmail.com>

* Fix minor typo in comment * Add matrix dimension check * Add descriptive comment

* Add solution * updating DIRECTORY.md * Fix pre-commit * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: John Law <johnlaw.po@gmail.com>

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-10-01T09:02:13Z

maths/points_are_collinear_3d.py

+    https://math.stackexchange.com/a/1951650
+"""
+
+Vector3d = tuple[float, float, float]


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: Vector3d

algorithms-keeper · 2022-10-01T09:02:14Z

maths/points_are_collinear_3d.py

+"""
+
+Vector3d = tuple[float, float, float]
+Point3d = tuple[float, float, float]


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: Point3d

algorithms-keeper · 2022-10-01T09:02:14Z

maths/points_are_collinear_3d.py

+    return tuple(round(x, accuracy) for x in vector) == (0, 0, 0)
+
+
+def are_collinear(a: Point3d, b: Point3d, c: Point3d, accuracy: int = 10) -> bool:


Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

Please provide descriptive name for the parameter: c

Bartechnika and others added 30 commits November 13, 2021 17:32

Add new persistence algorithm (#4751)

9b9405f

* Created new persistence algorithm * Update persistence.py * Added another persistence function

Replace typing.optional with new annotations syntax (#5829)

1ae5abf

* Replace typing.optional with new annotations syntax * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

Lowercase g --> Capital G (#5845)

f4a16f6

* Updated the comments in the code * Update .gitignore * Update .gitignore * Update .gitignore Co-authored-by: Christian Clauss <cclauss@me.com>

Added memoization function in fibonacci (#5856)

65d3cff

* Added memoization function in fibonacci * Minor changes

Improve Quine–McCluskey algorithm (#4935)

9af2eef

* Syntax improvements (I hope) to boolean algebra * Reverted certain index variables to i * remove extra line on decimal_to_binary * Update quine_mc_cluskey.py Co-authored-by: John Law <johnlaw.po@gmail.com>

ci: add mkdir step for mypy (#5927)

7423875

* ci: add mkdir step for mypy * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

Scrape anime and play episodes on browser without ads from terminal (#…

d28ac64

…5975) * fetch anime * formatted code * fix format errors * fix bot reviews * pr review fixes * remove unussed exception * change var name * fix comments

Extend power iteration to handle complex Hermitian input matrices (#5925

54f765b

) * works python3 -m unittest discover --start-directory src --pattern "power*.py" --t . -v * cleanup * revert switch to unittest * fix flake8

Upgrade to Python 3.10 (#5992)

f707f6d

* Upgrade to Python 3.10 * Upgrade to Python 3.10 * mypy || true * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

Added average absolute deviation (#5951)

7a9b3c7

* Added average absolute deviation * Formats program with black * reruns updated pre commit * Update average_absolute_deviation.py Co-authored-by: Christian Clauss <cclauss@me.com>

LICENSE: Year change (#5920)

37200a4

* 📝 Updated year Fixes: #5916 * Update LICENSE.md Co-authored-by: John Law <johnlaw.po@gmail.com>

fix(pre-commit): update black version (#6075)

4064bf4

black==22.1.0 is breaking the hook. Updating it to 22.3.0 fixes all the issue Refer: python-poetry/poetry#5375

feat: add strings/ngram algorithm (#6074)

1f1daaf

* feat: added ngram algorithm * fix(test): use `math.isclose` to match floating point numbers approximately Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

Fix some typos (#6113)

e1ec661

* Fix some typos. * Update volume.py Co-authored-by: John Law <johnlaw.po@gmail.com>

fix black at prefix string (#6122)

7a39441

* fix black at prefix string * Type -> type * Type unused

Add solution to Problem 145 of Project Euler (#5464)

4bd5494

* Solution to Problem 145 of Project Euler * Provided more descriptive filename * Update sol1.py Co-authored-by: John Law <johnlaw.po@gmail.com>

Add sol for P104 Project Euler (#5257)

26f2df7

* Hacktoberfest: added sol for P104 Project Euler * bot requests resolved * pre-commit * Update sol.py * Update sol.py * remove trailing zeroes * Update sol.py * Update sol.py * Update sol.py Co-authored-by: John Law <johnlaw.po@gmail.com>

MaximSmolskiy and others added 15 commits August 6, 2022 19:34

perf: improve Project Euler problem 203 solution 1 (#6279)

defc205

Improve solution (locally 1500+ times - from 3+ seconds to ~2 milliseconds) Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

typo corrected: heart -> Earth (#6275)

9eac958

feat: add Project Euler problem 114 solution 1 (#6300)

a69d880

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

feat: add Project Euler problem 115 solution 1 (#6303)

063a0ec

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

Add Max Fenwick Tree (#6298)

f46ce47

* Add `MaxFenwickTree` * Reformat code style * Fix type hints * Fix type hints again * Complete docstring * Complete docstring * Fix typo in file name * Change MaxFenwickTree into 0-based indexing * Fix Bugs * Minor fix

chore: remove the PayPal badge (#6348)

4e4fe95

Fix Max Fenwick Tree (#6328)

81e30fd

Add Optimized Shell Sort (#6225)

45d3eab

* Add Optimized Shell Sort * Added return type * reformatted * added shrink_shell.py * ran directory generator * Rename shrink_shell.py to shrink_shell_sort.py Co-authored-by: John Law <johnlaw.po@gmail.com>

fix typo (#6375)

5754bd0

Fix minor typo and add matrix dimension check (#6367)

91c671e

* Fix minor typo in comment * Add matrix dimension check * Add descriptive comment

Add Project Euler problem 116 solution 1 (#6305)

a0b0f41

* Add solution * updating DIRECTORY.md * Fix pre-commit * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: John Law <johnlaw.po@gmail.com>

ruchirmehta07 requested review from cclauss, dhruvmanila and Kush1101 as code owners October 1, 2022 09:01

algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files require descriptive names This PR needs descriptive function and/or variable names labels Oct 1, 2022

algorithms-keeper bot reviewed Oct 1, 2022

View reviewed changes

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 1, 2022

dhruvmanila added invalid and removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass documentation This PR modified documentation files require descriptive names This PR needs descriptive function and/or variable names labels Oct 1, 2022

dhruvmanila closed this Oct 1, 2022

TheAlgorithms locked as spam and limited conversation to collaborators Oct 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Invalid issue raised #6448

Invalid issue raised #6448

ruchirmehta07 commented Oct 1, 2022

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 1, 2022

algorithms-keeper bot Oct 1, 2022

algorithms-keeper bot Oct 1, 2022

		return tuple(round(x, accuracy) for x in vector) == (0, 0, 0)


		def are_collinear(a: Point3d, b: Point3d, c: Point3d, accuracy: int = 10) -> bool:

Invalid issue raised #6448

Invalid issue raised #6448

Conversation

ruchirmehta07 commented Oct 1, 2022

Describe your change:

Checklist:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 1, 2022

Choose a reason for hiding this comment

algorithms-keeper bot Oct 1, 2022

Choose a reason for hiding this comment

algorithms-keeper bot Oct 1, 2022

Choose a reason for hiding this comment