Skip to content

renamed gcd() to greatest_comman_divisor() #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

ksharma20
Copy link
Contributor

Fixed naming convention as described in Contribution.md

Expand acronyms because gcd() is hard to understand but greatest_common_divisor() is not.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

fixed naming convension as described in Contribution.md

> Expand acronyms because gcd() is hard to understand but greatest_common_divisor() is not.
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jul 24, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 24, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 24, 2022
@dhruvmanila
Copy link
Member

Thank you! 🎉

@dhruvmanila dhruvmanila merged commit 7d9ebee into TheAlgorithms:master Jul 24, 2022
@ksharma20 ksharma20 deleted the Fixing-Naming-Convensions branch July 24, 2022 17:02
@ksharma20
Copy link
Contributor Author

Thank you! 🎉

I am really glad @dhruvmanila, that I was able to contribute.
I am new to this open source contributing environment.
But, I still would like to learn more and contribute even further.
So can you guide me, what are other things or places where I can contribute or help ?
And Assign me some tasks etc If possible ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants